Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cointop: unstable -> 1.2.0 #61669

Merged
merged 1 commit into from May 23, 2019
Merged

cointop: unstable -> 1.2.0 #61669

merged 1 commit into from May 23, 2019

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This errors on startup - I'm not sure why the app crashes on startup. I will file a bug upstream in a few moments.

@matthiasbeyer
Copy link
Contributor Author

Bug filed in cointop-sh/cointop#32

@JohnAZoidberg
Copy link
Member

Works for me. What's your error?

@matthiasbeyer
Copy link
Contributor Author

See the issue description in cointop-sh/cointop#32

@JohnAZoidberg
Copy link
Member

I don't really see one. I just see their place holder text. Or am I missing something?

@matthiasbeyer
Copy link
Contributor Author

matthiasbeyer commented May 19, 2019 •
edited

oh, I don't know why the paste went wrong. Damn. Here we go.

tomberek
tomberek approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions on Ubuntu. No reverse dependencies.

@matthiasbeyer @marsam
cointop: 2018-05-03 -> 1.2.0
105d274 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@marsam
Copy link
Contributor

marsam commented May 23, 2019

I took the liberty to update it to buildGoModule. I hope you don't mind.

@ofborg ofborg bot requested review from marsam and kalbasit May 23, 2019 23:15
@marsam marsam merged commit 1b698b8 into NixOS:master May 23, 2019
@matthiasbeyer matthiasbeyer deleted the update-cointop branch May 24, 2019 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@marsam marsam Awaiting requested review from marsam

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthiasbeyer @JohnAZoidberg @marsam @tomberek