Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/matomo: fixing the configuration path #67556

Merged
merged 1 commit into from Aug 27, 2019
Merged

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 27, 2019

Motivation for this change

Matomo configuration has been moved under share/config by upstream and replaced with a symlink. The startup script ends up copying the symlink instead of the content of the directory, making the installation fail as it tries to write to the nix store.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @florianjacob

@mmahut mmahut merged commit b40ee82 into NixOS:master Aug 27, 2019
@florianjacob
Copy link
Contributor

Thank you, good catch! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants