Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtmidi: add PulseAudio support #67553

Merged
merged 1 commit into from
Sep 12, 2019
Merged

rtmidi: add PulseAudio support #67553

merged 1 commit into from
Sep 12, 2019
+6 −6

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Aug 27, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @magnetophon

Sorry, something went wrong.

worldofpeace
worldofpeace suggested changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change platforms to unix and use with stdenv.lib;?

@Moredread
Copy link
Contributor Author

Can you change platforms to unix and use with stdenv.lib;?

rtmidi should work on Darwin and compiles on the 19.03 branch atm just fine, e.g. https://hydra.nixos.org/build/98258688

It also doesn't look like we need to check the platform when adding to buildInputs, as alsaLib is linux only and rtaudio builds on Hydra. Or am I'm missing something?

I've refactored usage of std.lib though.

@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 7, 2019 •
edited
Loading

rtmidi should work on Darwin and compiles on the 19.03 branch atm just fine, e.g. https://hydra.nixos.org/build/98258688

It also doesn't look like we need to check the platform when adding to buildInputs, as alsaLib is linux only and rtaudio builds on Hydra. Or am I'm missing something?

Not sure where I meant those things, platforms.unix is identical to platforms; linux ++ darwin;.
So it just makes sense to use platforms.unix.

@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 7, 2019 •
edited
Loading

@GrahamcOfBorg build rtmidi

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 7, 2019
@Moredread
Copy link
Contributor Author

@worldofpeace oh sorry, didn't know that unix means both. I've changed it.

@worldofpeace
Copy link
Contributor

It seems the latest commit doesn't add pulseaudio to buildInputs. And technically this doesn't support darwin properly, but that's for another PR perhaps.

@Moredread
Copy link
Contributor Author

@worldofpeace Not sure how I missed that, but I fixed it I hope. :)

Thanks!

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 12, 2019
@worldofpeace worldofpeace merged commit 5c8c3d6 into NixOS:master Sep 12, 2019
@Moredread Moredread deleted the rtaudio-pulseaudio branch September 12, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @worldofpeace @lheckemann