Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NixOS/auto-upgrade: add gzip to service path #67587

Merged
merged 1 commit into from Sep 15, 2019
Merged

NixOS/auto-upgrade: add gzip to service path #67587

merged 1 commit into from Sep 15, 2019

Conversation

jollheef
Copy link
Member

Resolves #28527

Motivation for this change

gzip is required for correct unpacking of tar.gz archives. If it's missing then it's impossible to use nixos-upgrade if there's the use of fetchTarball for tar.gz archives, which is common across configurations that relies on external stuff.

Example of error:

unpacking 'https://gitlab.com/simple-nixos-mailserver/nixos-mailserver/-/archive/v2.2.1/nixos-mailserver-v2.2.1.tar.gz'...
tar (child): gzip: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
error: program 'tar' failed with exit code 2
(use '--show-trace' to show detailed location information)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Member

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bjornfor bjornfor merged commit d4e8f79 into NixOS:master Sep 15, 2019
@bjornfor
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-upgrade fails when using fetchTarball with a .tar.gz
3 participants