3proxy: init at 0.8.13 #67507

misuzu · 2019-08-26T14:48:03Z

Motivation for this change

New package

Things done

Notify maintainers

balsoft

LGTM!

pkgs/applications/networking/3proxy/default.nix

balsoft · 2019-08-26T15:13:25Z

@GrahamcOfBorg build _3proxy

pkgs/applications/networking/3proxy/default.nix

mmahut · 2019-08-27T08:57:42Z

@GrahamcOfBorg build _3proxy

misuzu · 2019-08-30T15:27:22Z

I have a module for 3proxy. Should i push it here or wait for this pull request to by merged?

alexarice

Builds with nix-review

mmahut · 2019-10-10T09:20:09Z

@misuzu feel free to include it here, as well as the test for the module.

@GrahamcOfBorg build _3proxy

mmahut · 2019-10-11T08:27:57Z

@GrahamcOfBorg test 3proxy

aanderse

Impressive first package. You've done a great job here!

aanderse · 2019-10-12T09:14:58Z

nixos/modules/services/networking/3proxy.nix

+        Ignore all other 3proxy options and load configuration from this file.
+      '';
+    };
+    users = mkOption {


I don't like options like this because it promotes bad user behavior and serves as more examples to other nixos developers on why it is ok to store secrets in the nix store (hint: it is not).

You have a usersFile option which covers the required functionality in a relatively simple way. What I'm suggesting is that you remove the users option in favor of usersFile. People who are entirely insistent on storing secrets in the nix store (or just want to quickly test with dummy data) are still free to write out something like:

services._3proxy.usersFile = pkgs.writeText '' user aanderse:CL:test '';

I want to make it very clear this is just my opinion and not required in order to have this PR merged.

nixos/modules/services/networking/3proxy.nix

aanderse · 2019-10-12T09:37:57Z

nixos/modules/services/networking/3proxy.nix

+      type = types.nullOr types.lines;
+      default = null;
+      description = ''
+        Extra configuration, appended to the 3proxy configuration file.


Please include link to upstream documentation.

Please wrap links like so <link xlink:href="https://github.com/z3APA3A/3proxy/wiki/3proxy.cfg"/> for easy clicking.

nixos/modules/services/networking/3proxy.nix

aanderse · 2019-10-12T09:42:49Z

nixos/modules/services/networking/3proxy.nix

+            type = types.nullOr types.lines;
+            default = null;
+            description = ''
+              Extra configuration for service.


As someone who has never used this program I would appreciate an explanation of what you put here, possibly including a link to the relevant section of upstream documentation.

misuzu · 2019-11-11T14:16:33Z

Rebased to fix merge conflict.

Unable to review at this time

aanderse · 2019-11-12T01:26:51Z

Sorry, I'm unable to continue with a review at this time. Ping @mmahut in case he is available.

nixos/modules/services/networking/3proxy.nix

7c6f434c · 2019-11-15T09:39:21Z

@volth @mmahut it looks like your comments have been addressed, right?

7c6f434c · 2019-11-27T17:12:19Z

Note that it looks like there is a Perl → Python NixOS test migration ongoing right now, so in future you probably should use the new Python test driver.

flokli · 2019-12-19T21:42:01Z

The nixos manual currently fails to build because of that:

⇒  nix-build nixos/release.nix -A manual.x86_64-linux
these derivations will be built:
  /nix/store/66fgw6v1w9qmb1f3bp8i45w0jisppjnj-nixos-manual-combined.drv
  /nix/store/wiwciawbfr5i0lmskyi0vhmpdg0p6z4f-manual-olinkdb.drv
  /nix/store/n5kmhmlzpf5jr5p7yb1za20q0pc0xkj5-nixos-manual-html.drv
building '/nix/store/66fgw6v1w9qmb1f3bp8i45w0jisppjnj-nixos-manual-combined.drv'...

manual-combined.xml:19885: element para: Relax-NG validity error : Did not expect element para there
 19881    </para></listitem>
 19882    <listitem><para>
 19883      <literal>"strong"</literal>: authentication by username/password. If user is not registered his access is denied regardless of ACLs.
 19884    </para></listitem>
 19885  </itemizedlist></para><para>Double authentication is possible, e.g.
 19886  <para>
 19887    {

manual-combined.xml:19885: element para: Relax-NG validity error : Expecting element example, got para
 19881    </para></listitem>
 19882    <listitem><para>
 19883      <literal>"strong"</literal>: authentication by username/password. If user is not registered his access is denied regardless of ACLs.
 19884    </para></listitem>
 19885  </itemizedlist></para><para>Double authentication is possible, e.g.
 19886  <para>
 19887    {

manual-combined.xml:19885: element para: Relax-NG validity error : Expecting element bridgehead, got para
 19881    </para></listitem>
 19882    <listitem><para>
 19883      <literal>"strong"</literal>: authentication by username/password. If user is not registered his access is denied regardless of ACLs.
 19884    </para></listitem>
 19885  </itemizedlist></para><para>Double authentication is possible, e.g.
 19886  <para>
 19887    {

manual-combined.xml:19885: element para: Relax-NG validity error : Element para has extra content: text
 19881    </para></listitem>
 19882    <listitem><para>
 19883      <literal>"strong"</literal>: authentication by username/password. If user is not registered his access is denied regardless of ACLs.
 19884    </para></listitem>
 19885  </itemizedlist></para><para>Double authentication is possible, e.g.
 19886  <para>
 19887    {

manual-combined.xml:19885: element para: Relax-NG validity error : Expecting element annotation, got para
 19881    </para></listitem>
 19882    <listitem><para>
 19883      <literal>"strong"</literal>: authentication by username/password. If user is not registered his access is denied regardless of ACLs.
 19884    </para></listitem>
 19885  </itemizedlist></para><para>Double authentication is possible, e.g.
 19886  <para>
 19887    {

manual-combined.xml fails to validate
builder for '/nix/store/66fgw6v1w9qmb1f3bp8i45w0jisppjnj-nixos-manual-combined.drv' failed with exit code 3
cannot build derivation '/nix/store/n5kmhmlzpf5jr5p7yb1za20q0pc0xkj5-nixos-manual-html.drv': 1 dependencies couldn't be built
error: build of '/nix/store/n5kmhmlzpf5jr5p7yb1za20q0pc0xkj5-nixos-manual-html.drv' failed

balsoft approved these changes Aug 26, 2019

View reviewed changes

pkgs/applications/networking/3proxy/default.nix Outdated Show resolved Hide resolved

misuzu force-pushed the package-3proxy branch from 2db8e74 to d93ef8b Compare August 26, 2019 14:53

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Aug 26, 2019

alexarice reviewed Aug 27, 2019

View reviewed changes

pkgs/applications/networking/3proxy/default.nix Outdated Show resolved Hide resolved

misuzu force-pushed the package-3proxy branch from d93ef8b to 79f2fb9 Compare August 27, 2019 07:50

mmahut reviewed Aug 27, 2019

View reviewed changes

pkgs/applications/networking/3proxy/default.nix Outdated Show resolved Hide resolved

mmahut reviewed Aug 27, 2019

View reviewed changes

pkgs/applications/networking/3proxy/default.nix Outdated Show resolved Hide resolved

mmahut reviewed Aug 27, 2019

View reviewed changes

pkgs/applications/networking/3proxy/default.nix Outdated Show resolved Hide resolved

misuzu force-pushed the package-3proxy branch from 79f2fb9 to bfdcf1e Compare August 27, 2019 08:08

misuzu force-pushed the package-3proxy branch from bfdcf1e to 9874ce2 Compare August 31, 2019 11:07

misuzu requested review from mmahut and alexarice October 9, 2019 22:14

alexarice approved these changes Oct 10, 2019

View reviewed changes

misuzu requested a review from infinisil as a code owner October 10, 2019 13:29

ofborg bot added 6.topic: nixos 8.has: module (update) labels Oct 10, 2019

mmahut requested a review from aanderse October 11, 2019 08:28

aanderse previously requested changes Oct 12, 2019

View reviewed changes

misuzu requested a review from aanderse October 12, 2019 12:29

ofborg bot added the 2.status: merge conflict label Nov 11, 2019

misuzu added 2 commits November 11, 2019 16:15

maintainers: added misuzu

b619c06

3proxy: init at 0.8.13

b571728

nixos/3proxy: init

08eb63b

misuzu force-pushed the package-3proxy branch from 3f2a68b to 08eb63b Compare November 11, 2019 14:16

ofborg bot removed the 2.status: merge conflict label Nov 11, 2019

7c6f434c reviewed Nov 12, 2019

View reviewed changes

nixos/modules/services/networking/3proxy.nix Show resolved Hide resolved

nixos/3proxy: note about htpasswd

823d669

misuzu requested a review from volth November 27, 2019 12:32

7c6f434c approved these changes Nov 27, 2019

View reviewed changes

7c6f434c merged commit 6210c15 into NixOS:master Dec 19, 2019

misuzu mentioned this pull request Dec 19, 2019

nixos/3proxy: manual validation fix #76069

Merged

10 tasks

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3proxy: init at 0.8.13 #67507

3proxy: init at 0.8.13 #67507

misuzu commented Aug 26, 2019 •

edited

balsoft left a comment

balsoft commented Aug 26, 2019

mmahut commented Aug 27, 2019

misuzu commented Aug 30, 2019

alexarice left a comment

mmahut commented Oct 10, 2019

mmahut commented Oct 11, 2019

aanderse left a comment

aanderse Oct 12, 2019

misuzu Oct 12, 2019

aanderse Oct 12, 2019

misuzu Oct 12, 2019

aanderse Oct 12, 2019

misuzu Oct 13, 2019 •

edited

aanderse Oct 12, 2019

misuzu Oct 12, 2019

misuzu commented Nov 11, 2019

aanderse commented Nov 12, 2019

7c6f434c commented Nov 15, 2019

7c6f434c commented Nov 27, 2019

flokli commented Dec 19, 2019

3proxy: init at 0.8.13 #67507

3proxy: init at 0.8.13 #67507

Conversation

misuzu commented Aug 26, 2019 • edited

Motivation for this change

Things done

Notify maintainers

balsoft left a comment

Choose a reason for hiding this comment

balsoft commented Aug 26, 2019

mmahut commented Aug 27, 2019

misuzu commented Aug 30, 2019

alexarice left a comment

Choose a reason for hiding this comment

mmahut commented Oct 10, 2019

mmahut commented Oct 11, 2019

aanderse left a comment

Choose a reason for hiding this comment

aanderse Oct 12, 2019

Choose a reason for hiding this comment

misuzu Oct 12, 2019

Choose a reason for hiding this comment

aanderse Oct 12, 2019

Choose a reason for hiding this comment

misuzu Oct 12, 2019

Choose a reason for hiding this comment

aanderse Oct 12, 2019

Choose a reason for hiding this comment

misuzu Oct 13, 2019 • edited

Choose a reason for hiding this comment

aanderse Oct 12, 2019

Choose a reason for hiding this comment

misuzu Oct 12, 2019

Choose a reason for hiding this comment

misuzu commented Nov 11, 2019

aanderse commented Nov 12, 2019

7c6f434c commented Nov 15, 2019

7c6f434c commented Nov 27, 2019

flokli commented Dec 19, 2019

misuzu commented Aug 26, 2019 •

edited

misuzu Oct 13, 2019 •

edited