Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tilt: 0.9.7 -> 0.10.4 #67532

Merged
merged 1 commit into from Aug 27, 2019
Merged

tilt: 0.9.7 -> 0.10.4 #67532

merged 1 commit into from Aug 27, 2019

Conversation

jlesquembre
Copy link
Member

Motivation for this change

tilt: 0.9.7 -> 0.10.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @anton-dessiatov

@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@GrahamcOfBorg build tilt

@jlesquembre
Copy link
Member Author

@mmahut wasn't tilt already build? I thought every PR is using OfBorg automatically. I'm asking because I should have permissions to call GrahamcOfBorg build ..., so I could do it for the next PR

@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@jlesquembre it did not build on darwin, given you are in the extra-known-users group, which allow you to build on x86_64 and aarch64. Darwin is little bit restricted, given the sandboxing is not working well on Mac OS X.

@mmahut mmahut merged commit 4b09f99 into NixOS:master Aug 27, 2019
@jlesquembre
Copy link
Member Author

jlesquembre commented Aug 27, 2019 •
edited

@mmahut Understand, thanks for explaining it, I wasn't aware of that restriction

@jlesquembre jlesquembre deleted the tilt branch August 27, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlesquembre @mmahut