Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kakounePlugins: Add 5 kakoune plugins #67593

Merged
merged 4 commits into from Sep 3, 2019
Merged

kakounePlugins: Add 5 kakoune plugins #67593

merged 4 commits into from Sep 3, 2019

Conversation

nrdxp
Copy link
Contributor

@nrdxp nrdxp commented Aug 27, 2019

Should be compatible with
#64310

  • kak-auto-pairs: for automatic closing of pairs
  • kak-buffers: for easier buffer management
  • kak-fzf: for fzf integration
  • kak-powerline: for a prettier modeline
  • kak-vertical-selection: for easy vertical selections
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @eraserhd @vrthra

@nrdxp
kakounePlugins: Add 5 kakoune plugins
b17d0d6 
Should be compatible with
NixOS#64310

* kak-auto-pairs: for automatic closing of pairs
* kak-buffers: for easier buffer management
* kak-fzf: for fzf integration
* kak-powerline: for a prettier modeline
* kak-vertical-selection: for easy vertical selections
nrdxp added a commit to nrdxp/nixos that referenced this pull request Aug 27, 2019
@nrdxp
add support for kakoune editor and some plugins
086ed57 
* uses plugins from NixOS/nixpkgs#67593
* define personal kakrc
* setup kak-lsp
* automatically place files with home-manager
eraserhd
eraserhd suggested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@eraserhd eraserhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I requested some minor changes wrt dependencies. I'll test on my Mac OS tomorrow.

pkgs/applications/editors/kakoune/plugins/kak-fzf.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/kakoune/plugins/kak-powerline.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/kakoune/plugins/default.nix Show resolved Hide resolved
@nrdxp nrdxp force-pushed the kakoune/plugins branch 2 times, most recently from 2ebfca1 to 2fdd7b6 Compare August 28, 2019 06:11
@nrdxp
Copy link
Contributor Author

nrdxp commented Aug 28, 2019

Hey @eraserhd I addressed all of your ideas with a couple of commits. Allowing a toggle between fzf and skim was a great idea. Thanks

@eraserhd
Copy link
Contributor

This looks good to me!

@aristidb aristidb merged commit 0b32fe2 into NixOS:master Sep 3, 2019
@nrdxp nrdxp deleted the kakoune/plugins branch January 6, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eraserhd eraserhd eraserhd requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nrdxp @eraserhd @aristidb