Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/orangefs: init at 2.9.7, add modules and test #67591

Merged
merged 3 commits into from
Oct 31, 2019
Merged

nixos/orangefs: init at 2.9.7, add modules and test #67591

merged 3 commits into from
Oct 31, 2019
+476 −0

Conversation

markuskowa
Copy link
Member

Motivation for this change

OrangeFS is a scalable high performance filesystem. It's client module is included in the upstream Linux kernel.

Things done
  • Add the package to nixpkgs
  • Added NixOS modules for server and client.
  • Added a test that tests a basic setup.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@markuskowa markuskowa requested a review from infinisil as a code owner August 27, 2019 22:22
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 27, 2019
@markuskowa
Copy link
Member Author

markuskowa commented Aug 27, 2019 •
edited
Loading

@GrahamcOfBorg test orangefs

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/49

@dtzWill
Copy link
Member

dtzWill commented Sep 7, 2019 •
edited
Loading

Kicking the tires on this, nix reports:

trace: warning: Option services.orangefs.client.fileSystems' has no description.`

Can you add a description for this?

EDIT: server.fileSystems too :).

@markuskowa markuskowa force-pushed the in-orangefs branch 2 times, most recently from 3153a74 to b87166f Compare September 7, 2019 19:16
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Sep 8, 2019
@dtzWill
orangefs: sync w/latest version of NixOS#67591
b7585ec
@Mic92 Mic92 changed the title orangefs/nioxs: init at 2.9.7, add modules and test nixos/orangefs: init at 2.9.7, add modules and test Sep 24, 2019
Mic92
Mic92 reviewed Sep 24, 2019
View reviewed changes
nixos/modules/services/network-filesystems/orangefs/client.nix Outdated
# and before mounts are done.
# Otherwise client daemon may hang.
preStart = "sleep 1";
postStart = "sleep 1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks hacky. Is this what upstream suggests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what fedora uses: https://src.fedoraproject.org/rpms/orangefs/blob/master/f/orangefs-client.service

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had problems in a virtualbox which looked like a race condition between mount and the client daemon. The way fedora does it is not the recommended way by upstream but it seems to work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know a different way, readiness could be checked instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling the client core directly may solve the problem and remove the internal startup delay.

The service creates a unix datagram socket. Is there a way to track that with systemd?

@markuskowa
nixos/orangefs: add modules for server and client
8b4ce06
@markuskowa
nixos/orangefs: add test

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
7ced973
@markuskowa
Copy link
Member Author

@Mic92 @dtzWill Should we move forward with PR?

@markuskowa markuskowa mentioned this pull request Oct 4, 2019
Merged
10 tasks
Mic92
Mic92 approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run through, code looks good to me!

@Mic92 Mic92 changed the title nixos/orangefs: init at 2.9.7, add modules and test nixos/orangefs: init at 2.9.7, add modules and test Oct 31, 2019
@Mic92 Mic92 merged commit c91a1be into NixOS:master Oct 31, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 31, 2019
@Mic92 @dtzWill
nixos/orangefs: init at 2.9.7, add modules and test (NixOS#67591)

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
6f21de4 
nixos/orangefs: init at 2.9.7, add modules and test

(cherry picked from commit c91a1be)
@markuskowa markuskowa deleted the in-orangefs branch May 27, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill

@Mic92 Mic92

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @nixos-discourse @dtzWill @Mic92