Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-desktop: use yarn2nix-moretea #67534

Merged
merged 1 commit into from Aug 26, 2019
Merged

riot-desktop: use yarn2nix-moretea #67534

merged 1 commit into from Aug 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2019 •
edited by ghost

Now that we have yarn2nix-moretea in the tree, we can use that instead of the vendored version that was introduced when yarn2nix was removed previously. Also add an update script.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ghost ghost mentioned this pull request Aug 26, 2019
Closed
10 tasks
@ofborg ofborg bot requested a review from worldofpeace August 26, 2019 21:24
pacien
pacien approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@pacien pacien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

pkgs/applications/networking/instant-messengers/riot/riot-desktop.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/instant-messengers/riot/update-riot-desktop.sh Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from worldofpeace August 26, 2019 21:56
riot-desktop: use yarn2nix-moretea
a9ae2c0 
Now that we have yarn2nix-moretea in the tree, we can use that instead of the vendored version that was introduced when yarn2nix was removed previously. Also add an update script.
@worldofpeace worldofpeace merged commit 8a86654 into NixOS:master Aug 26, 2019
@ofborg ofborg bot requested a review from worldofpeace August 26, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @worldofpeace