Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayback_machine_downloader: init at 2.2.1 #67533

Merged
merged 2 commits into from Aug 28, 2019
Merged

wayback_machine_downloader: init at 2.2.1 #67533

merged 2 commits into from Aug 28, 2019

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Aug 26, 2019

Motivation for this change

Just used it myself

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@GrahamcOfBorg build wayback_machine_downloader

@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@GrahamcOfBorg build wayback_machine_downloader

@WilliButz WilliButz merged commit 07054b4 into NixOS:master Aug 28, 2019
@manveru manveru deleted the add-wayback_machine_downloader branch December 12, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@alexarice alexarice alexarice left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manveru @mmahut @alexarice @WilliButz