cpython: skip macOS system frameworks #67470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don’t want cpython picking up /Library/Frameworks and /System/Library/Frameworks which contains Tcl.framework. Instead it should use the one provided by Nix. this would not be an issue if sandboxing was enabled, but unfortunately that has its own issues. Fixes NixOS#66647
|
Similar fix is probably needed in 2.7/default.nix
…On Mon, Aug 26, 2019, 02:37 Matthew Bauer ***@***.***> wrote:
@matthewbauer <https://github.com/matthewbauer> requested your review on:
#67470 <#67470> cpython: skip macOS
system frameworks.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#67470?email_source=notifications&email_token=AAQHZ3ZXPSAR66O5ZGI2HPTQGMQVJA5CNFSM4IPKXZCKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTHU3GFA#event-2582229780>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQHZ36E73ZMF3RURO6OLMTQGMQVJANCNFSM4IPKXZCA>
.
|
It didn't happen for me on python2. Not sure why though. |
|
Thanks! I thought the reason 2.7/default.nix doesn't need this is because it applies use-correct-tcl-tk-on-darwin.patch. |
|
Good catch! Yeah that makes sense |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don’t want cpython picking up /Library/Frameworks and
/System/Library/Frameworks which contains Tcl.framework. Instead it
should use the one provided by Nix. this would not be an issue if
sandboxing was enabled, but unfortunately that has its own issues.
Fixes #66647
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @