Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs-irony: fix build #67471

Merged
merged 2 commits into from Aug 26, 2019
Merged

emacs-irony: fix build #67471

merged 2 commits into from Aug 26, 2019

Conversation

matthewbauer
Copy link
Member

Fixes #66556

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthewbauer
melpa-packages.nix: remove generic
b993fb0 
This file does not exist
@mmahut
Copy link
Member

mmahut commented Aug 26, 2019

@GrahamcOfBorg build emacsPackagesNg.melpaPackages.irony

@mmahut mmahut merged commit d42ae52 into NixOS:master Aug 26, 2019
@alexarice
Copy link
Contributor

@matthewbauer is irony working for you after this pr, I'm getting

(void-function irony-cdb-autosetup-compile-options)

and am trying to work out if I am doing something wrong or if the package has somehow gone weird after the update

@alexarice
Copy link
Contributor

alexarice commented Aug 30, 2019 •
edited

ignore this, I have fixed the issue by adding (require 'irony-cdb) to my config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emacs irony doesn't build
3 participants
@matthewbauer @mmahut @alexarice