Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: enable loadable sqlite extensions #67472

Merged
merged 1 commit into from Aug 31, 2019
Merged

python: enable loadable sqlite extensions #67472

merged 1 commit into from Aug 31, 2019

Conversation

matthewbauer
Copy link
Member

Our sqlite supports it, so might as well make use of it.

Fixes #66526

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
Copy link
Member

FRidh commented Aug 26, 2019

The modified file is only used by Python 3.

@matthewbauer
Copy link
Member Author

The modified file is only used by Python 3.

I think this only works on python 3:

https://bugs.python.org/issue10268

@matthewbauer matthewbauer changed the base branch from master to staging August 26, 2019 19:53
@artemist
Copy link
Member

Now that you've changed the base to staging, can you cherry-pick your commit onto origin/staging and force push back here? That should clean up the merge conflicts and make GitHub a lot less mad when trying to view differences.

@matthewbauer @disassembler
python: enable loadable sqlite extensions
70f2174 
Our sqlite supports it, so might as well make use of it.

Fixes NixOS#66526
@disassembler disassembler merged commit 98662eb into NixOS:staging Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: emacs 6.topic: erlang 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthewbauer @FRidh @artemist @teto @disassembler