Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vde2: build with --disable-python by default #67452

Merged
merged 1 commit into from Aug 27, 2019
Merged

vde2: build with --disable-python by default #67452

merged 1 commit into from Aug 27, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 25, 2019 •
edited

Motivation for this change

This package explicitly depends on python2 which will be EOLed at the
end of the year[1]. This package provides python bindings for python2,
however the latest release (also used by other distros) is from 2011[2]
and doesn't support v3. For instance, debian ships vde2 without
python2 support since Debian Jessie[3].

KVM and QEMU appear to build fine, also NixOS tests and ISO builds are
still functional.

By running nix-review against this change, only xen packages failed,
but those were already broken on master[4].

Finally it's also worth mentioning that the closure size of vde2 drops
from 99.5M to 33.5M without python2 according to nix path-info -S -h.

[1] https://pythonclock.org/
[2] https://github.com/virtualsquare/vde-2/releases/tag/vde-2
(vde.sourceforge.net redirects to this github page)
[3] https://packages.debian.org/en/jessie/vde2
[4] https://hydra.nixos.org/build/99185451, https://hydra.nixos.org/build/99187262

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 requested review from dtzWill and FRidh August 25, 2019 16:28
@teto
Copy link
Member

teto commented Aug 26, 2019

withPython might better stand the test of time (doesn't have to be changed once they upgrade to python3).

Is it normal that the version number doesn't match the url 2.3.1 vs 2.3.2 ?
"mirror://sourceforge/vde/vde2/2.3.1/${name}.tar.gz
I am fond of the pname/version distinction so that might be a complementary change.

@Ma27
Copy link
Member Author

Ma27 commented Aug 26, 2019

Is it normal that the version number doesn't match the url 2.3.1 vs 2.3.2 ?
"mirror://sourceforge/vde/vde2/2.3.1/${name}.tar.gz
I am fond of the pname/version distinction so that might be a complementary change.

When I change 2.3.1 to 2.3.2 I still get the same tarball with the same hash (the tarball's name is equal to ${name}, so the version number is correct, but for some reason 2.3.1 is in the URL).

Regarding the pname/version thing: I'd actually prefer to get this changed all at once automatically for consistency reasons and so we don't have to do it manually 😅

withPython might better stand the test of time (doesn't have to be changed once they upgrade to python3).

You're right. I mainly focused on the ongoing python2 migration, however we might want to have this feature flag after that in case of python3 support as well. (Also, we currently pass python2 into the package, so it's still rather obvious that python2 is currently needed).

@Ma27
vde2: build with --disable-python by default
904d624 
This package explicitly depends on `python2` which will be EOLed at the
end of the year[1]. This package provides python bindings for `python2`,
however the latest release (also used by other distros) is from 2011[2]
and doesn't support v3. For instance, debian ships `vde2` without
`python2` support since Debian Jessie[3].

KVM and QEMU appear to build fine, also NixOS tests and ISO builds are
still functional.

By running `nix-review` against this change, only `xen` packages failed,
but those were already broken on master[4].

Finally it's also worth mentioning that the closure size of `vde2` drops
from 99.5M to 33.5M without `python2` according to `nix path-info -S -h`.

[1] https://pythonclock.org/
[2] https://github.com/virtualsquare/vde-2/releases/tag/vde-2
    (vde.sourceforge.net redirects to this github page)
[3] https://packages.debian.org/en/jessie/vde2
[4] https://hydra.nixos.org/build/99185451, https://hydra.nixos.org/build/99187262
@Ma27 Ma27 force-pushed the build-vde2-without-python2 branch from 60ce648 to 904d624 Compare August 26, 2019 07:29
@Ma27
Copy link
Member Author

Ma27 commented Aug 26, 2019

Updated the PR accordingly.

@Ma27
Copy link
Member Author

Ma27 commented Aug 26, 2019

@GrahamcOfBorg eval

@FRidh FRidh merged commit b4a4d98 into NixOS:master Aug 27, 2019
@Ma27 Ma27 deleted the build-vde2-without-python2 branch August 27, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @teto @FRidh