Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab-runner: add missing HOME to environment #67450

Merged
merged 1 commit into from Aug 28, 2019
Merged

nixos/gitlab-runner: add missing HOME to environment #67450

merged 1 commit into from Aug 28, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Aug 25, 2019

Motivation for this change

Gitlab runner fails to start if HOME is not set.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @max-wittig

@bachp
nixos/gitlab-runner: add missing HOME to environment
83b4e03 
Gitlab runner fails to start if HOME is not set.
@bachp
Copy link
Member Author

bachp commented Aug 28, 2019

/cc @zimbatm

@zimbatm zimbatm merged commit 02ed974 into NixOS:master Aug 28, 2019
@zimbatm
Copy link
Member

zimbatm commented Aug 28, 2019

was that a new issue? the previous upgrade must not have been tested properly

@bachp bachp deleted the gitlab-runner-home branch August 29, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bachp @zimbatm