Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport go updates to 19.03 #67485

Merged
merged 7 commits into from Aug 26, 2019
Merged

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Refs #66894 (comment)
Cherry-picked all 1.11 and 1.12 go updates from master.
@kalbasit I was not sure if you wanted both versions to be backported or only 1.11.13 - did both, let me know if 1.12 changes should be removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kalbasit

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build go_1_11 go_1_12

@kalbasit
Copy link
Member

It's perfect, thank you @rvolosatovs

@kalbasit kalbasit merged commit e67da9e into NixOS:release-19.03 Aug 26, 2019
@johanot johanot mentioned this pull request Aug 27, 2019
10 tasks
@rvolosatovs rvolosatovs deleted the backport/go branch September 6, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants