Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astyle: use cmake to avoid having to manually manage the build #67486

Merged
merged 1 commit into from Aug 26, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

upstream supports cmake so use that in order to no longer have special logic for clang/gcc and linux/darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg merged commit 780e656 into NixOS:master Aug 26, 2019
@peterhoeg peterhoeg deleted the f/astyle branch August 26, 2019 10:47
@peterhoeg peterhoeg restored the f/astyle branch August 26, 2019 14:26
@peterhoeg peterhoeg deleted the f/astyle branch August 27, 2019 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant