Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: 2.5.3 -> 2.6.3, rubygems 3.0.3 -> 3.0.6 #67597

Closed
wants to merge 4 commits into from
Closed

ruby: 2.5.3 -> 2.6.3, rubygems 3.0.3 -> 3.0.6 #67597

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2019 •
edited by ghost

Superseeds #54582

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Milan Pässler and others added 3 commits August 28, 2019 02:28
ruby: rubygems 3.0.3 -> 3.0.6
0d75d5e
@alyssais
ruby: --disable-rubygems for baseruby
45f296d 
This works just fine, and means we don't run into an issue with RubyGems
trying to install into a different Ruby's prefix when cross-compiling.
See #51842 (comment).
@alyssais
ruby: replace bundled RubyGems with our RubyGems
7561e60 
This should prevent problems caused by trying to install our own
RubyGems over the top of the one that comes with Ruby.
@ghost ghost requested review from alyssais and zimbatm as code owners August 28, 2019 00:33
@ofborg ofborg bot added the 6.topic: ruby label Aug 28, 2019
@ofborg ofborg bot requested review from manveru and vrthra August 28, 2019 00:47
@ghost
Copy link
Author

ghost commented Aug 28, 2019

Tho following packages can not be built:

airwave futhark inav libsForQt511.khotkeys libtensorflow python27Packages.baselines python27Packages.dm-sonnet python27Packages.edward python27Packages.graph_nets python27Packages.tensorflow python27Packages.tensorflow-probability python27Packages.tensorflowWithCuda python27Packages.tflearn python37Packages.optuna python37Packages.tensorflowWithCuda qgis qgis-unwrapped qmc2 quodlibet quodlibet-full quodlibet-without-gst-plugins quodlibet-xine quodlibet-xine-full sleepyhead

All of those fail on unstable too, so we should be good to go 👍

@alyssais
ruby: 2.5.5 -> 2.6.3
1bc4071 
According to nix-review, this does not introduce any new build failures and I
had it run on my systems for a while, but there might be breakages at runtime.

Since I'm not going to go through every Ruby package one at a time, I
think the best thing to do is bump this so we can get bug reports of
breakages from people who actually use those packages.
@alyssais alyssais mentioned this pull request Aug 31, 2019
Closed
10 tasks
@alyssais
Copy link
Member

Rebased and pushed to staging.

@alyssais alyssais closed this Aug 31, 2019
@alyssais
Copy link
Member

Thanks very much for collecting everything @petabyteboy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

@manveru manveru Awaiting requested review from manveru

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alyssais