Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unixODBCDrivers.msodbcsql17: 17.2.0.1 -> 17.4.1.1 #67594

Merged
merged 1 commit into from Aug 28, 2019
Merged

unixODBCDrivers.msodbcsql17: 17.2.0.1 -> 17.4.1.1 #67594

merged 1 commit into from Aug 28, 2019

Conversation

spencerjanssen
Copy link
Contributor

@spencerjanssen spencerjanssen commented Aug 27, 2019 •
edited

Motivation for this change

The old 17.2.0.1 version no longer builds because it looks for libssl.so and libcrypto.so versions that don't exist. The new version doesn't require these libraries.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

aanderse
aanderse approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • compile on NixOS
  • test connecting to mssql database from NixOS

LGTM 👍

Thanks! 🎉

@aanderse aanderse merged commit af71811 into NixOS:master Aug 28, 2019
@aanderse
Copy link
Member

@spencerjanssen I recently updated to 19.09 and suddenly this is no longer working for me. Error is

[08001][Microsoft][ODBC Driver 17 for SQL Server]SSL Provider: [OpenSSL library could not be loaded, make sure OpenSSL 1.0 or 1.1 is installed]
[08001][Microsoft][ODBC Driver 17 for SQL Server]Client unable to establish connection

I'm confused because I specifically tested this and it had worked... 🤔 Is everything working on your setup on 19.09?

@aanderse aanderse mentioned this pull request Oct 21, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spencerjanssen @aanderse