Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson: 0.50.1 → 0.51.2 #67596

Merged
merged 1 commit into from Aug 28, 2019
Merged

meson: 0.50.1 → 0.51.2 #67596

merged 1 commit into from Aug 28, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 28, 2019

https://mesonbuild.com/Release-notes-for-0-51-0.html

Issues like mesonbuild/meson#5502 and mesonbuild/meson#5643
appear to be fixed. folks and sway now build.

@ofborg ofborg bot requested a review from rasendubi August 28, 2019 00:50
@worldofpeace worldofpeace mentioned this pull request Aug 28, 2019
Closed
10 tasks
@jtojnar jtojnar mentioned this pull request Aug 28, 2019
Merged
@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 28, 2019 •
edited

Built packages
  • ✔️ json-glib
  • ✔️ fwupd
  • ✔️ python3.pkgs.pycairo
  • ✔️ gnome3.gnome-shell
  • ✔️ sway
  • ✔️ folks
  • ✔️ gnome3.gnome-software

@zimbatm
Copy link
Member

zimbatm commented Aug 28, 2019

nice work!

was meson supported on darwin before?

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 28, 2019

The version is now available on pypi, switched to that. Verified that the sources are the same.

was meson supported on darwin before?

Yup.

@worldofpeace
Copy link
Contributor

Built packages
* heavy_check_mark json-glib

* heavy_check_mark fwupd

* heavy_check_mark python3.pkgs.pycairo

* heavy_check_mark gnome3.gnome-shell

* heavy_check_mark sway

* heavy_check_mark folks

* heavy_check_mark gnome3.gnome-software

Ah and to think you had to do this twice. Thanks 👍 .

@worldofpeace
Copy link
Contributor

was meson supported on darwin before?

Pretty sure darwin is in a poor state on staging anyway. So I don't think we can check if it builds here 😦

@jtojnar jtojnar merged commit 2d00fed into NixOS:staging Aug 28, 2019
@jtojnar jtojnar deleted the meson-0.51.2 branch August 28, 2019 22:31
@vcunat
Copy link
Member

vcunat commented Sep 4, 2019 •
edited

Hydra shows SDL on darwin as a new breakage due to meson, but I haven't looked how many packages get transitively affected there.

applying patch /nix/store/zdk6szyq326hbgqqpmsynf3f2fi0s0x9-fix-objc-linking.patch
patching file mesonbuild/environment.py
Hunk #1 FAILED at 795.
Hunk #2 FAILED at 822.
2 out of 2 hunks FAILED -- saving rejects to file mesonbuild/environment.py.rej
builder for '/nix/store/hbcrbwi35vpacbyf1vnds6glhkc8akr0-meson-0.51.2.drv' failed with exit code 1

@vcunat
Copy link
Member

vcunat commented Sep 4, 2019

Upstream claims to have fixed the darwin issue in mesonbuild/meson@1ea3ddc6ad74, but that's apparently not in any release yet.

@jtojnar
Copy link
Contributor Author

jtojnar commented Sep 4, 2019

@vcunat weird, not sure how I missed this. Let me rebase the patch.

jtojnar added a commit to jtojnar/nixpkgs that referenced this pull request Sep 4, 2019
@jtojnar
meson: fix darwin patch
1be0350 
Somehow I missed this in NixOS#67596
@jtojnar jtojnar mentioned this pull request Sep 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@rasendubi rasendubi Awaiting requested review from rasendubi

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @zimbatm @worldofpeace @vcunat