python3Packages.pre-commit: 1.18.1 -> 1.18.2 #67509
Conversation
|
|
There was a problem hiding this comment.
nix-review passes on NixOS
diff LGTM
executables seem to work
leaf package
https://github.com/NixOS/nixpkgs/pull/67509
2 package were build:
pre-commit python27Packages.pre-commit
@FRidh when i run the pre-commit package in an environment with python27Packages.pre-commit (such as nix-review shell), i seem to be inheriting some of those packages even with a wrapped program. Should we just disallow receiving pythonpaths from environment as part of the wrapping process?
$ ./results/pre-commit/bin/pre-commit --help
Traceback (most recent call last):
File "/nix/store/921z4azpr87cnjc1mip8sk7vghkkqh83-pre-commit-1.18.2/bin/.pre-commit-wrapped", line 7, in <module>
from pre_commit.main import main
File "/nix/store/m4pigfn9lphmcdqa9nfjz159ivj91f1c-pre-commit-1.18.2/lib/python2.7/site-packages/pre_commit/main.py", line 11, in <module>
from pre_commit import git
File "/nix/store/m4pigfn9lphmcdqa9nfjz159ivj91f1c-pre-commit-1.18.2/lib/python2.7/site-packages/pre_commit/git.py", line 7, in <module>
from pre_commit.util import cmd_output
File "/nix/store/m4pigfn9lphmcdqa9nfjz159ivj91f1c-pre-commit-1.18.2/lib/python2.7/site-packages/pre_commit/util.py", line 18, in <module>
from importlib.resources import open_binary
File "/nix/store/yglc8kgzmdaskyngv90y1mw96fl00pjy-python3-3.7.4/lib/python3.7/importlib/resources.py", line 11, in <module>
from typing import Iterable, Iterator, Optional, Set, Union # noqa: F401
File "/nix/store/44gm1b72bh2ry0pb0n5yi2rncj8lgx04-python2.7-typing-3.6.6/lib/python2.7/site-packages/typing.py", line 624, in <module>
AnyStr = TypeVar('AnyStr', bytes, unicode)
NameError: name 'unicode' is not defined
from pkgs/applications/version-management/git-and-tools/default.nix:
pre-commit = pkgs.python3Packages.toPythonApplication pkgs.python3Packages.pre-commit;
|
@jonringer |
|
Yea, that's what i realized was happening, by default nix-review drops you into a nix-shell and my PYTHONPATH was inheriting ALL of the python packages. I still think it would be nice to have a "isolated" python wrapping process which will insulate a given python application from receiving PYTHONPATH (such as unsetting it before the wrapper calls into the python application). |
Motivation for this change
Version update
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @