Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action intermittently fails to label pull requests #18704

Closed
jugglinmike opened this issue Aug 27, 2019 · 8 comments
Closed

GitHub Action intermittently fails to label pull requests #18704

jugglinmike opened this issue Aug 27, 2019 · 8 comments
Labels
GitHub Actions infra priority:backlog

Comments

@jugglinmike
Copy link
Contributor

The GitHub Action named "Synchronize the Pull Request Preview" which ran for gh-18602 failed with the following message:

INFO:__main__:Adding label
INFO:__main__:Issuing request: POST https://api.github.com/repos/web-platform-tests/wpt/issues/18602/labels
Traceback (most recent call last):
  File "tools/ci/update_pr_preview.py", line 253, in <module>
    code = main(sys.argv[1])
  File "tools/ci/update_pr_preview.py", line 225, in main
    github.add_label(pr_number, active_label)
  File "tools/ci/update_pr_preview.py", line 161, in add_label
    request(url, 'post', json_data=data)
  File "tools/ci/update_pr_preview.py", line 65, in request
    resp.raise_for_status()
  File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.github.com/repos/web-platform-tests/wpt/issues/18602/labels
##[error]Docker run failed with exit code 1

Reviewing recently-filed pull requests, this appears to be an intermittent error. At first, I thought it was because the pull request comes from a fork. Even though we explicitly tested for that, the GitHub Actions beta has recently undergone some drastic changes. But gh-18619 demonstrates that it's still possible for this GitHub Action to run under these conditions.

Since we know GitHub Actions to be unstable and since this particular Action doesn't influence the "mergeable" status of the pull requests, we may want to wait until the feature leaves "beta" before researching much further.
@jugglinmike jugglinmike mentioned this issue Aug 27, 2019
Merged
@foolip
Copy link
Member

foolip commented Aug 27, 2019

This looks like it's probably an issue with the GitHub API's availability, rather than anything about GitHub Actions. Could it be a quota issue?

@jugglinmike
Copy link
Contributor Author

GitHub's API rate limits are pretty generous for authenticated requests. I'm wondering if there's a problem with the token granted to this Action. Then again, I know nothing about how tokens are assigned to Actions.

@foolip
Copy link
Member

foolip commented Aug 27, 2019

Are there other PRs from forks where this worked?

@jugglinmike jugglinmike mentioned this issue Aug 27, 2019
Merged
@jugglinmike
Copy link
Contributor Author

Yup; gh-18619 is an example

@foolip
Copy link
Member

foolip commented Aug 27, 2019

Have you also found PRs where the PR owner does have write access to the wpt repo and still uses a fork, as is the case with #18602? I don't expect that difference matters, but... dunno?

@jugglinmike
Copy link
Contributor Author

gh-18693 seems to fit the bill

@foolip
Copy link
Member

foolip commented Aug 27, 2019

Argh :)

I wonder if retrying gh-18602 will "fix" the problem? If so it might suggest we need retry logic.

@BorisChiou BorisChiou mentioned this issue Sep 10, 2019
Merged
@foolip
Copy link
Member

foolip commented May 6, 2021

This job is no longer running.

@foolip foolip closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GitHub Actions infra priority:backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foolip @jugglinmike