Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-shadowsocks2: init at 0.0.11 #67516

Merged
merged 2 commits into from Oct 30, 2019
Merged

go-shadowsocks2: init at 0.0.11 #67516

merged 2 commits into from Oct 30, 2019

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Aug 26, 2019

Motivation for this change

This PR adds go-shadowsocks2 and a module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxzi oxzi requested a review from infinisil as a code owner August 26, 2019 17:59
infinisil
infinisil approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@infinisil infinisil changed the title go-shadowsocks2: init at 0.0.11 go-shadowsocks2: init at 0.0.11 Oct 30, 2019
@infinisil infinisil merged commit 90e3039 into NixOS:master Oct 30, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 30, 2019
@infinisil @dtzWill
go-shadowsocks2: init at 0.0.11 (NixOS#67516)
4871110 
go-shadowsocks2: init at 0.0.11
(cherry picked from commit 90e3039)
@oxzi oxzi deleted the shadowsocks2-0.0.11 branch October 30, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@alexarice alexarice alexarice left review comments

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxzi @mmahut @alexarice @infinisil