Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exiv2: 0.27.1 -> 0.27.2 #67453

Merged
merged 2 commits into from Aug 26, 2019
Merged

exiv2: 0.27.1 -> 0.27.2 #67453

merged 2 commits into from Aug 26, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 25, 2019 •
edited

Motivation for this change

Fixes #67194

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member Author

mmahut commented Aug 25, 2019

@GrahamcOfBorg build empathy

@worldofpeace
Copy link
Contributor

I have

    # Fix tests on Aarch64

in the expression. Can we check if that's fixed?

@mmahut
Copy link
Member Author

mmahut commented Aug 26, 2019

Can we check if that's fixed?

It looks like it does, yay.

@mmahut
Copy link
Member Author

mmahut commented Aug 26, 2019

Did a full rebuild over night, no new broken packages.

@mmahut mmahut merged commit 3052cc1 into NixOS:master Aug 26, 2019
@worldofpeace
Copy link
Contributor

Did a full rebuild over night, no new broken packages.

Excellent, thanks 👍

worldofpeace
worldofpeace reviewed Aug 26, 2019
View reviewed changes
pkgs/development/libraries/exiv2/default.nix
@@ -58,8 +53,6 @@ stdenv.mkDerivation rec {
"doc"
];

doCheck = stdenv.isLinux;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doCheck is default false so this disabled them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh :(

mmahut added a commit to mmahut/nixpkgs that referenced this pull request Aug 26, 2019
@mmahut
exiv2: enabling tests for real
9b4e5a9 
Fixes NixOS#67453
@mmahut mmahut mentioned this pull request Aug 26, 2019
Merged
10 tasks
@ckauhaus ckauhaus mentioned this pull request Sep 12, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 74: exiv2-0.27.1: 1 advisory
2 participants
@mmahut @worldofpeace