Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qarte: use qt5’s mkDerivation and an other fix #67544

Merged
merged 2 commits into from Sep 12, 2019
Merged

qarte: use qt5’s mkDerivation and an other fix #67544

merged 2 commits into from Sep 12, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Aug 27, 2019

Motivation for this change

qarte fails to run (cc #65399).

Regarding QtMultimedia for pyqt, I made it opt-in as it seems to increase a lot the closure size of pyqt5 (257·10⁶ before, 313·10⁶ after) and would otherwise impact a lot of packages that I’d rather not touch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @svanderburg (pyqt5)

@vbgl
qarte: use qt5’s mkDerivation
e063d08 
See NixOS#65399
@vbgl
qarte: use pyqt5_with_qtmultimedia
ef15478 
Otherwise, qarte fails at run-time with:

>     from PyQt5.QtMultimedia import QMediaPlayer
> ModuleNotFoundError: No module named 'PyQt5.QtMultimedia'
@vbgl vbgl requested a review from FRidh as a code owner August 27, 2019 06:29
@ofborg ofborg bot requested a review from svanderburg August 27, 2019 06:44
@FRidh
Copy link
Member

FRidh commented Aug 27, 2019

please add an import test in pyqt.

@vbgl
Copy link
Contributor Author

vbgl commented Aug 27, 2019

Isn’t that line adding such an import test?

ef15478#diff-19144d919f970a62bd3090d650f6a88bR126

@vbgl
Copy link
Contributor Author

vbgl commented Sep 5, 2019

May I merge this?

@vbgl vbgl merged commit bf75933 into NixOS:master Sep 12, 2019
@vbgl vbgl deleted the qarte+fix-qt-platform branch September 12, 2019 15:31
@ahiaao ahiaao mentioned this pull request Nov 17, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @FRidh