Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.DeviceSerialPort: name -> pname #67481

Merged
merged 1 commit into from Aug 26, 2019
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

My fix for the broken master wasn't quite as awesome as it should have been...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@peterhoeg peterhoeg merged commit 2b0098a into NixOS:master Aug 26, 2019
@peterhoeg peterhoeg deleted the f/perl branch August 26, 2019 07:51
@peterhoeg peterhoeg restored the f/perl branch August 26, 2019 09:58
@peterhoeg peterhoeg deleted the f/perl branch August 26, 2019 10:07
@peterhoeg
Copy link
Member Author

This wasn't really supposed to happen. I was merging some stuff that had been lingering around, which accidentally broke master (the PR really should have been rebased).

Do you need me to change this back or will the bot take care of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant