Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.elpy: 1.28.0 -> 1.29.1 add tests #67518

Merged
merged 1 commit into from Aug 27, 2019
Merged

pythonPackages.elpy: 1.28.0 -> 1.29.1 add tests #67518

merged 1 commit into from Aug 27, 2019

Conversation

costrouc
Copy link
Member

Motivation for this change

Latest version of elpy works with black

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@costrouc costrouc requested a review from FRidh as a code owner August 26, 2019 18:15
@costrouc
Copy link
Member Author

nix-review passes

Result of nix-review pr 67518 1

2 package were build:
  • python27Packages.elpy
  • python37Packages.elpy

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.elpy python2Packages.elpy

@costrouc
Copy link
Member Author

Ready for merge.

@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@GrahamcOfBorg build pythonPackages.elpy python3Packages.elpy

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.elpy python2Packages.elpy

1 similar comment
@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@GrahamcOfBorg build python3Packages.elpy python2Packages.elpy

@mmahut mmahut merged commit 5a097da into NixOS:master Aug 27, 2019
This was referenced Sep 19, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@costrouc @mmahut