Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-up: 1.4.2 -> 1.6.1 #67517

Merged
merged 1 commit into from Oct 2, 2019
Merged

git-up: 1.4.2 -> 1.6.1 #67517

merged 1 commit into from Oct 2, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

fixing @r-ryantm update failures.

bumped python2 to python3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peterhoeg

@ofborg ofborg bot requested a review from peterhoeg August 26, 2019 18:28
@peterhoeg
Copy link
Member

Why not just change python2Packages to python3Packages?

@jonringer
Copy link
Contributor Author

future proofing for python4.

Just kidding, but I've written enough python packages to not like know explicitly which version is being handed to me.

@peterhoeg
Copy link
Member

@FRidh, do you prefer the derivation to be specific about the python version (python2Packages vs python3Packages), or simply to take a pythonPackages and then have all-packages.nix override accordingly?

@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@GrahamcOfBorg build git-up

ck3d
ck3d approved these changes Sep 28, 2019
View reviewed changes
Copy link
Contributor

@ck3d ck3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested executable bin/git-up

@mmahut
Copy link
Member

mmahut commented Sep 28, 2019

Please fix the merge conflict.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build git-up

rebased off master

Lassulus
Lassulus approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, run nix-up on nixpkgs which failed with Failed to rebase upstream/release-18.09 onto 18.09 and then tested it on some other repos which worked ok.

@Lassulus Lassulus merged commit fe24628 into NixOS:master Oct 2, 2019
@jonringer jonringer deleted the bump-git-up branch October 2, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@ck3d ck3d ck3d approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonringer @peterhoeg @mmahut @Lassulus @ck3d