Inventory: Fix missing setModified calls

SmallJoker · SmallJoker · commit 1d3f5af7c060 · 2019-08-25T09:46:54.000+02:00
Previously inv:remove_item and inv:set_list did not trigger an inventory update
diff --git a/src/inventory.cpp b/src/inventory.cpp
@@ -685,6 +685,8 @@ ItemStack InventoryList::removeItem(const ItemStack &item)
 				break;
 		}
 	}
+	if (!removed.empty())
+		setModified();
 	return removed;
 }
 
@@ -936,15 +938,18 @@ InventoryList * Inventory::addList(const std::string &name, u32 size)
 		{
 			delete m_lists[i];
 			m_lists[i] = new InventoryList(name, size, m_itemdef);
+			m_lists[i]->setModified();
 		}
 		return m_lists[i];
 	}
 
 
 	//don't create list with invalid name
-	if (name.find(' ') != std::string::npos) return NULL;
+	if (name.find(' ') != std::string::npos)
+		return nullptr;
 
 	InventoryList *list = new InventoryList(name, size, m_itemdef);
+	list->setModified();
 	m_lists.push_back(list);
 	return list;
 }

Original file line number	Diff line number	Diff line change
`@@ -685,6 +685,8 @@ ItemStack InventoryList::removeItem(const ItemStack &item)`
`685`	`685`	`break;`
`686`	`686`	`}`
`687`	`687`	`}`
	`688`	`+ if (!removed.empty())`
	`689`	`+ setModified();`
`688`	`690`	`return removed;`
`689`	`691`	`}`
`690`	`692`
`@@ -936,15 +938,18 @@ InventoryList * Inventory::addList(const std::string &name, u32 size)`
`936`	`938`	`{`
`937`	`939`	`delete m_lists[i];`
`938`	`940`	`m_lists[i] = new InventoryList(name, size, m_itemdef);`
	`941`	`+ m_lists[i]->setModified();`
`939`	`942`	`}`
`940`	`943`	`return m_lists[i];`
`941`	`944`	`}`
`942`	`945`
`943`	`946`
`944`	`947`	`//don't create list with invalid name`
`945`		`- if (name.find(' ') != std::string::npos) return NULL;`
	`948`	`+ if (name.find(' ') != std::string::npos)`
	`949`	`+ return nullptr;`
`946`	`950`
`947`	`951`	`InventoryList *list = new InventoryList(name, size, m_itemdef);`
	`952`	`+ list->setModified();`
`948`	`953`	`m_lists.push_back(list);`
`949`	`954`	`return list;`
`950`	`955`	`}`