Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashplayer: 32.0.0.223 -> 32.0.0.238 #67431

Merged
merged 1 commit into from Aug 25, 2019
Merged

flashplayer: 32.0.0.223 -> 32.0.0.238 #67431

merged 1 commit into from Aug 25, 2019

Conversation

masaeedu
Copy link
Contributor

@masaeedu masaeedu commented Aug 25, 2019

PS: We should probably centralize this flash player version somewhere. Someone updated the number for the firefox browser, but this was left behind apparently.

Motivation for this change

Flash player version is out of date, and the site where it's hosted keeps deleting old versions so things break.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @taku0 (last committer to this file)

@masaeedu
Copy link
Contributor Author

There's a bug in the CI I think, I was anticipating this would fail and spit out a SHA mismatch.

@masaeedu
Copy link
Contributor Author

Should be fine now.

@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

Thank you for fixing this.

@mmahut mmahut merged commit 7d0adb4 into NixOS:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants