Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-desktop: 3.9.2895 -> 3.10.2904, mac 3.9.2943 -> 3.10.3133 #67557

Merged
merged 1 commit into from Aug 27, 2019
Merged

wire-desktop: 3.9.2895 -> 3.10.2904, mac 3.9.2943 -> 3.10.3133 #67557

merged 1 commit into from Aug 27, 2019

Conversation

toonn
Copy link
Contributor

@toonn toonn commented Aug 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace (I couldn't test building on linux.)

P.s.: Is there an easy way to get the correct hash for a different platform than the one you're on? I had to change the expression to specify the linux source in the darwin parts to get the hash.

@ofborg ofborg bot requested a review from worldofpeace August 27, 2019 11:26
@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

@GrahamcOfBorg build wire-desktop

@mmahut mmahut merged commit b31d5fe into NixOS:master Aug 27, 2019
@worldofpeace
Copy link
Contributor

@toonn The most simple way to do this is like

 nix eval -f .  wire-desktop.src.urls --argstr "system" "x86_64-darwin"
[ "https://github.com/wireapp/wire-desktop/releases/download/macos%2F3.10.3133/Wire.pkg" ]

 nix eval -f .  wire-desktop.src.urls --argstr "system" "x86_64-linux"
[ "https://wire-app.wire.com/linux/debian/pool/main/Wire-3.10.2904_amd64.deb" ]

(be sure to change the versions in the expression.)

and use nix-prefetch-url on the urls for the hashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toonn @mmahut @worldofpeace