Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onnxruntime: init at 0.5.0 #67542

Merged
merged 1 commit into from Oct 2, 2019
Merged

onnxruntime: init at 0.5.0 #67542

merged 1 commit into from Oct 2, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Onnxruntime is a scoring engine for ML models. Somewhat of a competitor against other scoring engines such as tensorflow.

This is just the initial starting point for cpu-enabled dynamically linked libraries. CUDA, MKL, and other refinements are due later. Not really feasible with how integrated their cmake + git-submodule layout is right now

cc @costrouc because he's into ML stuff.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

closure size:

$ nix path-info -Sh ./result
/nix/store/pnq3kfg37cv6cxmhccwcpiqhw4gz95qv-onnxruntime-0.5.0     40.5M

just relies on gcc (for the time being):

$ nix-store -q --tree ./result
/nix/store/pnq3kfg37cv6cxmhccwcpiqhw4gz95qv-onnxruntime-0.5.0
+---/nix/store/iykxb0bmfjmi7s53kfg6pjbfpd8jmza6-glibc-2.27
|   +---/nix/store/iykxb0bmfjmi7s53kfg6pjbfpd8jmza6-glibc-2.27 [...]
+---/nix/store/pjx3f50x0qziyivs7rbg5s12p99nn2np-gcc-7.4.0-lib
    +---/nix/store/iykxb0bmfjmi7s53kfg6pjbfpd8jmza6-glibc-2.27 [...]
    +---/nix/store/pjx3f50x0qziyivs7rbg5s12p99nn2np-gcc-7.4.0-lib [...]
$ tree ./result/
./result/
└── lib
    ├── libonnxruntime.so -> libonnxruntime.so.0.5.0
    └── libonnxruntime.so.0.5.0

the result-dev/lib/cmake/protobuf is from onnxruntime doing a add_subdirectory on the entire protobuf codebase.

$ tree -L 3 ./result-dev
./result-dev
├── include
│   └── onnxruntime
│       └── core
├── lib
│   └── cmake
│       └── protobuf
└── nix-support
    └── propagated-build-inputs

@jonringer
Copy link
Contributor Author

@marsam could you review :)

Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor comments

pkgs/development/libraries/onnxruntime/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/onnxruntime/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/onnxruntime/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build onnxruntime

@marsam marsam merged commit 9c673c4 into NixOS:master Oct 2, 2019
@jonringer jonringer deleted the add-onnxruntime branch October 2, 2019 14:57
@jonringer
Copy link
Contributor Author

thanks @marsam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants