Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and modernize our C# code #2303

Merged
merged 5 commits into from
Aug 25, 2019
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Aug 25, 2019

Applied by hand some of the suggestions made by ReSharper.

pleroy added 3 commits August 25, 2019 11:02

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
ksp_plugin_adapter/flight_planner.cs Outdated Show resolved Hide resolved
ksp_plugin_adapter/flight_planner.cs Show resolved Hide resolved
ksp_plugin_adapter/gl_lines.cs Show resolved Hide resolved
ksp_plugin_adapter/ksp_plugin_adapter.cs Outdated Show resolved Hide resolved
ksp_plugin_adapter/ksp_plugin_adapter.cs Outdated Show resolved Hide resolved
ksp_plugin_adapter/main_window.cs Show resolved Hide resolved
ksp_plugin_adapter/window_renderer.cs Outdated Show resolved Hide resolved
ksp_plugin_adapter/window_renderer.cs Outdated Show resolved Hide resolved
@@ -142,7 +137,7 @@ protected BaseWindowRenderer(UnityEngine.GUILayoutOption[] options)
id : GetHashCode(),
screenRect : new UnityEngine.Rect(
x : (UnityEngine.Screen.width - rectangle_.width) / 2,
y : UnityEngine.Screen.height / 3,
y : (float)UnityEngine.Screen.height / 3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ 3f (and comment than y is float so 3.0 would double-round.

Sorry, something went wrong.

@pleroy
Copy link
Member Author

pleroy commented Aug 25, 2019

retest this please

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Aug 25, 2019
@pleroy pleroy merged commit 3cfb0e2 into mockingbirdnest:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants