Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and modernize our C# code #2303

Merged
merged 5 commits into from
Aug 25, 2019
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Aug 25, 2019

Applied by hand some of the suggestions made by ReSharper.

ksp_plugin_adapter/flight_planner.cs Outdated Show resolved Hide resolved
ksp_plugin_adapter/flight_planner.cs Show resolved Hide resolved
ksp_plugin_adapter/gl_lines.cs Show resolved Hide resolved
ksp_plugin_adapter/ksp_plugin_adapter.cs Outdated Show resolved Hide resolved
public event Action render_windows;
public event Action ClearLocks;
public event Action DisposeWindows;
public event Action RenderWindows;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to change style for events? We had consistendly been using snake_case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us go with BactrianCamelCase but noun phrases.

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but I am unconvinced.

Sorry, something went wrong.

ksp_plugin_adapter/ksp_plugin_adapter.cs Outdated Show resolved Hide resolved
ksp_plugin_adapter/main_window.cs Show resolved Hide resolved
ksp_plugin_adapter/window_renderer.cs Outdated Show resolved Hide resolved
ksp_plugin_adapter/window_renderer.cs Outdated Show resolved Hide resolved
@pleroy
Copy link
Member Author

pleroy commented Aug 25, 2019

retest this please

@eggrobin eggrobin added the LGTM label Aug 25, 2019
@pleroy pleroy merged commit 3cfb0e2 into mockingbirdnest:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants