Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bab74a4e2b4c
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 616f9de82e7b
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Aug 25, 2019

  1. Problems found on Linux.

    pleroy committed Aug 25, 2019
    Copy the full SHA
    da20352 View commit details
  2. Merge pull request #2304 from pleroy/Linux

    Fix problems found on Linux
    pleroy authored Aug 25, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    616f9de View commit details
2 changes: 1 addition & 1 deletion astronomy/geodesy_test.cpp
Original file line number Diff line number Diff line change
@@ -176,7 +176,7 @@ TEST_F(GeodesyTest, LAGEOS2) {
EXPECT_THAT(
AbsoluteError((primary_actual_final_dof.position() - ITRS::origin).Norm(),
(expected_final_dof.position() - ITRS::origin).Norm()),
IsNear(894_⑴ * Metre));
IsNear(0.89_⑴ * Kilo(Metre)));

// Errors in orbital elements.
KeplerianElements<ICRS> const expected_elements =
2 changes: 1 addition & 1 deletion astronomy/orbital_elements_test.cpp
Original file line number Diff line number Diff line change
@@ -188,7 +188,7 @@ TEST_F(OrbitalElementsTest, KeplerOrbit) {
// Mean element values.
EXPECT_THAT(elements.mean_semimajor_axis_interval().midpoint(),
AbsoluteErrorFrom(*initial_osculating.semimajor_axis,
Lt(330 * Micro(Metre))));
Lt(410 * Micro(Metre))));
EXPECT_THAT(elements.mean_eccentricity_interval().midpoint(),
AbsoluteErrorFrom(*initial_osculating.eccentricity,
Lt(4.6e-11)));
28 changes: 14 additions & 14 deletions astronomy/solar_system_dynamics_test.cpp
Original file line number Diff line number Diff line change
@@ -291,8 +291,8 @@ TEST_F(SolarSystemDynamicsTest, TenYearsFromJ2000) {
{SolarSystemFactory::Jupiter,
{/*separation_per_orbit=*/0.033516_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.000013_⑴ * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/0.010381_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/0.074355_⑴ * ArcSecond}},
/*longitude_of_ascending_node_drift_per_orbit=*/0.0103_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/0.074_⑴ * ArcSecond}},
{SolarSystemFactory::Saturn,
{/*separation_per_orbit=*/0.017580_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.000850_⑴ * ArcSecond,
@@ -322,7 +322,7 @@ TEST_F(SolarSystemDynamicsTest, TenYearsFromJ2000) {
{/*separation_per_orbit=*/0.054834_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.0000027_⑴ * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/0.000644_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/0.025516_⑴ * ArcSecond}},
/*argument_of_periapsis_drift_per_orbit=*/0.02552_⑴ * ArcSecond}},
{SolarSystemFactory::Mercury,
{/*separation_per_orbit=*/0.189560_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.0000037_⑴ * ArcSecond,
@@ -393,22 +393,22 @@ TEST_F(SolarSystemDynamicsTest, TenYearsFromJ2000) {
{/*separation_per_orbit=*/0.039264_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.001664_⑴ * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/0.609354_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/0.637784_⑴ * ArcSecond}},
/*argument_of_periapsis_drift_per_orbit=*/0.63778_⑴ * ArcSecond}},
{SolarSystemFactory::Callisto,
{/*separation_per_orbit=*/0.000271_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.000449_⑴ * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/0.161789_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/0.160001_⑴ * ArcSecond}},
/*argument_of_periapsis_drift_per_orbit=*/0.16000_⑴ * ArcSecond}},
{SolarSystemFactory::Io,
{/*separation_per_orbit=*/0.076859_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.000715_⑴ * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/3.63026_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/3.61361_⑴ * ArcSecond}},
/*argument_of_periapsis_drift_per_orbit=*/3.6136_⑴ * ArcSecond}},
{SolarSystemFactory::Europa,
{/*separation_per_orbit=*/0.065995_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.004845_⑴ * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/0.100670_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/0.077509_⑴ * ArcSecond}},
/*argument_of_periapsis_drift_per_orbit=*/0.07751_⑴ * ArcSecond}},

{SolarSystemFactory::Titan,
{/*separation_per_orbit=*/0.159615_⑴ * ArcSecond,
@@ -450,7 +450,7 @@ TEST_F(SolarSystemDynamicsTest, TenYearsFromJ2000) {
{/*separation_per_orbit=*/0.837069_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.038544_⑴ * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/0.532907_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/0.521766_⑴ * ArcSecond}},
/*argument_of_periapsis_drift_per_orbit=*/0.52176_⑴ * ArcSecond}},

{SolarSystemFactory::Titania,
{/*separation_per_orbit=*/0.070049_⑴ * ArcSecond,
@@ -485,21 +485,21 @@ TEST_F(SolarSystemDynamicsTest, TenYearsFromJ2000) {
/*argument_of_periapsis_drift_per_orbit=*/0.022413_⑴ * ArcSecond}},

{SolarSystemFactory::Phobos,
{/*separation_per_orbit=*/1.3529_⑴ * ArcSecond,
{/*separation_per_orbit=*/1.352_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.0015_⑴ * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/0.133_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/0.349_⑴ * ArcSecond}},
{SolarSystemFactory::Deimos,
{/*separation_per_orbit=*/0.00683_⑴ * ArcSecond,
{/*separation_per_orbit=*/0.0068_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.002945_⑴ * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/0.215807_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/0.2131_⑴ * ArcSecond}},
/*longitude_of_ascending_node_drift_per_orbit=*/0.21581_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/0.213_⑴ * ArcSecond}},

{SolarSystemFactory::Charon,
{/*separation_per_orbit=*/254.946459_⑴ * ArcSecond,
/*inclination_drift_per_orbit=*/0.000086_⑴ * ArcSecond,
/*longitude_of_ascending_node_drift_per_orbit=*/0.113176_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/512.625135_⑴ * ArcSecond}},
/*longitude_of_ascending_node_drift_per_orbit=*/0.11318_⑴ * ArcSecond,
/*argument_of_periapsis_drift_per_orbit=*/512.625_⑴ * ArcSecond}},
};

for (int const planet_or_minor_planet :
2 changes: 1 addition & 1 deletion physics/geopotential_test.cpp
Original file line number Diff line number Diff line change
@@ -767,7 +767,7 @@ TEST_F(GeopotentialTest, DampedForces) {
(get_radial_acceleration(earth_geopotential, (s0 + s1) / 2) -
get_radial_acceleration(*geopotential_j2, (s0 + s1) / 2)) /
get_radial_acceleration(*geopotential_c22_s22, (s0 + s1) / 2),
AlmostEquals(1, 210, 1142));
AlmostEquals(1, 111, 1142));
EXPECT_THAT(
(get_latitudinal_acceleration(earth_geopotential, (s0 + s1) / 2) -
get_latitudinal_acceleration(*geopotential_j2, (s0 + s1) / 2)) /
1 change: 1 addition & 0 deletions physics/rotating_body_body.hpp
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
#include "physics/rotating_body.hpp"

#include <algorithm>
#include <optional>
#include <vector>

#include "geometry/grassmann.hpp"
2 changes: 1 addition & 1 deletion testing_utilities/approximate_quantity.hpp
Original file line number Diff line number Diff line change
@@ -97,7 +97,7 @@ class ApproximateQuantity<double> {
double min_multiplier_;
double max_multiplier_;

static constexpr double unit_ = 1;
double const unit_ = 1;

template<typename Right>
friend ApproximateQuantity<Right> operator-(