Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix firefox 60 #67426

Closed
wants to merge 2 commits into from
Closed

fix firefox 60 #67426

wants to merge 2 commits into from

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Aug 25, 2019

Since a rust update #66686, browsers based on Firefox 60 ESR didn't build anymore:

error: trait objects without an explicit dyn are deprecated

  • verify the firefox-esr-60 build (at least)

I just copied the whole directory and reverted the bump of version+hash.
We don't seem likely to want to touch this again, so copying simplifies
future updates to rust.  I can't see why not keep the rest as in 1.37,
including the binary 1.36 for bootstrap.

Motivation: older firefox versions won't build with 1.37.
Attributes: firefox-esr-60, tor-browser(-8-5), icecat
@vcunat
Copy link
Member Author

vcunat commented Aug 25, 2019

Hmm, rust-bindgen also seems affected by this error. We could switch it to older rust as well, but I'd assume it's better to fix by updating, if possible; /cc maintainer @Ralith.

@vcunat
Copy link
Member Author

vcunat commented Aug 25, 2019

Also /cc the staging-next thread containing these regressions: #66822.

@vcunat
Copy link
Member Author

vcunat commented Aug 25, 2019

Now I verified firefoxPackages.tor-browser build as well.

@symphorien
Copy link
Member

(Untested) Alternatively, the flag --cap-lints warn could probably be passed to rustc (with the RUSTFLAGS environment variable for example).

vcunat added a commit that referenced this pull request Aug 25, 2019
vcunat added a commit that referenced this pull request Aug 25, 2019
Attributes: firefox-esr-60, tor-browser(-8-5), icecat
Thanks to Symphorien: #67426
@vcunat
Copy link
Member Author

vcunat commented Aug 25, 2019

Right, that seems much better for this case. I re-verified the vanilla ESR 60, so let me go forward with that: bc238b8.

@vcunat vcunat closed this Aug 25, 2019
@Ralith
Copy link
Contributor

Ralith commented Aug 25, 2019

Should we arrange for that to be the default when building rust in nixpkgs? Failing builds due to warnings seems liable to be a source of constant churn otherwise, for the same reasons why -Werror should never be passed to a C/C++ compiler for distribution builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants