New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix firefox 60 #67426
fix firefox 60 #67426
Conversation
I just copied the whole directory and reverted the bump of version+hash. We don't seem likely to want to touch this again, so copying simplifies future updates to rust. I can't see why not keep the rest as in 1.37, including the binary 1.36 for bootstrap. Motivation: older firefox versions won't build with 1.37.
Attributes: firefox-esr-60, tor-browser(-8-5), icecat
Hmm, |
Also /cc the staging-next thread containing these regressions: #66822. |
Now I verified |
(Untested) Alternatively, the flag |
Attributes: firefox-esr-60, tor-browser(-8-5), icecat Thanks to Symphorien: #67426
Right, that seems much better for this case. I re-verified the vanilla ESR 60, so let me go forward with that: bc238b8. |
Should we arrange for that to be the default when building rust in nixpkgs? Failing builds due to warnings seems liable to be a source of constant churn otherwise, for the same reasons why |
Since a rust update #66686, browsers based on Firefox 60 ESR didn't build anymore:
firefox-esr-60
build (at least)