Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightspark: init at 0.8.1 #67425

Merged
merged 1 commit into from Aug 31, 2019
Merged

lightspark: init at 0.8.1 #67425

merged 1 commit into from Aug 31, 2019

Conversation

jchv
Copy link
Contributor

@jchv jchv commented Aug 25, 2019

Motivation for this change

Lightspark is an open source Flash Player implementation.

I put this in misc because Gnash is also in misc. If there is a better place please advise.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

@GrahamcOfBorg build lightspark

@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

@GrahamcOfBorg build lightspark

@aanderse
Copy link
Member

@jchv any access to a mac to fix the darwin build?

@jchv
Copy link
Contributor Author

jchv commented Aug 31, 2019

I don’t think Lightspark officially supports macOS, and may not support it at all. I can take a deeper look.

@disassembler
Copy link
Member

@jchv change platforms to linux instead of all if that's the case.

@jchv
Copy link
Contributor Author

jchv commented Aug 31, 2019

@disassembler Thanks, didn't realize my mistake until now :)

@disassembler
Copy link
Member

@GrahamcOfBorg build lightspark

@disassembler disassembler merged commit e3aaada into NixOS:master Aug 31, 2019
disassembler added a commit that referenced this pull request Aug 31, 2019
@disassembler
Merge remote-tracking branch 'upstream/master' into staging-next
4b515cf 
* upstream/master:
  vimPlugins: update (#67823)
  mattermost-desktop: 4.2.0 -> 4.2.3 (#67717)
  lightspark: init at 0.8.1 (#67425)
  anki: 2.1.11 -> 2.1.14 (#67738)
  nixos/{namecoind,bitcoind}: removing the altcoin prefix
  rust-cbindgen: 0.8.7 -> 0.9.0
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 19, 2019
@jchv @dtzWill
lightspark: init at 0.8.1 (NixOS#67425)
29f6ac4 
(cherry picked from commit e3aaada)
@jchv jchv deleted the add-lightspark branch May 28, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jchv @mmahut @aanderse @disassembler