Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elmPackages: share node-env.nix, add elm-live & elm-xref #67439

Merged
merged 1 commit into from Aug 28, 2019
Merged

elmPackages: share node-env.nix, add elm-live & elm-xref #67439

merged 1 commit into from Aug 28, 2019

Conversation

turboMaCk
Copy link
Member

Reusing shared nix-env - see discussion in this PR. I've also added 2 more node tools which seems to be widely used

  • elm-live
  • elm-xref
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar

@domenkozar
Copy link
Member

@GrahamcOfBorg build elmPackages

@turboMaCk
Copy link
Member Author

I see failure here I'm going to investigate and fix the problem - will ping you later.

@turboMaCk
Copy link
Member Author

@GrahamcOfBorg build elmPackages

@turboMaCk
Copy link
Member Author

turboMaCk commented Aug 27, 2019 •
edited

@domenkozar I think I got it. Seems there is some problem with elm-analyse@0.16.4 pinning version to 0.16.3 fixes nix-build -A elmPackages on my machine. I've squshed commits to one.

@turboMaCk turboMaCk force-pushed the elm-packages/improvements-and-additions branch from 3692c8f to eb5ba59 Compare August 27, 2019 20:02
@domenkozar
Copy link
Member

@GrahamcOfBorg build elmPackages

@turboMaCk
Copy link
Member Author

I really can't really express how much I aprichiate that you find time to review all the thing I've generated in past few months in words. You're my OSS hero of the 2019 for sure, thanks <3

@domenkozar domenkozar merged commit aa31307 into NixOS:master Aug 28, 2019
@domenkozar
Copy link
Member

You're welcome - seems like macOS failures are unrelated and due to macos machine issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turboMaCk @domenkozar