Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: 2.5.3 -> 2.6.3 #67564

Closed
wants to merge 4 commits into from
Closed

ruby: 2.5.3 -> 2.6.3 #67564

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2019 •
edited by ghost

Motivation for this change

Superseeds #54582
To fix rubygems/rubygems#2587, we use our own rubygems instead of the one bundled with ruby.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Milan Pässler and others added 4 commits August 27, 2019 12:15
ruby: rubygems 3.0.3 -> 3.0.6
6db7e90
@alyssais
ruby: 2.5.3 -> 2.6.3
250b007 
I tested this with nix-review a little while ago and everything built
okay, but breakages are likely to occur at runtime anyway.

Since I'm not going to go through every Ruby package one at a time, I
think the best thing to do is bump this so we can get bug reports of
breakages from people who actually use those packages.
@alyssais
ruby: --disable-rubygems for baseruby
4784c94 
This works just fine, and means we don't run into an issue with RubyGems
trying to install into a different Ruby's prefix when cross-compiling.
See #51842 (comment).
@alyssais
ruby: replace bundled RubyGems with our RubyGems
a4c2a94 
This should prevent problems caused by trying to install our own
RubyGems over the top of the one that comes with Ruby.
@ghost ghost requested review from alyssais and zimbatm as code owners August 27, 2019 12:27
@ofborg ofborg bot added the 6.topic: ruby label Aug 27, 2019
@ofborg ofborg bot requested review from manveru and vrthra August 27, 2019 12:40
@ghost
Copy link
Author

ghost commented Aug 27, 2019

I am running this through nix-review and it seems like it breaks quite a few things. I'm looking into it right now.

@ghost
Copy link
Author

ghost commented Aug 28, 2019

should be targeted at staging

@ghost ghost closed this Aug 28, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

@manveru manveru Awaiting requested review from manveru

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gem build ../foo.gemspec does not work anymore
1 participant
@alyssais