Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nginx: use mailcap mime.types #67566

Merged
merged 1 commit into from Oct 9, 2019
Merged

nixos/nginx: use mailcap mime.types #67566

merged 1 commit into from Oct 9, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2019 •
edited by ghost

fixes #61186

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from c0bw3b August 27, 2019 13:23
nixos/nginx: use mailcap mime.types
71bc558 
The mime type definitions included with nginx are very incomplete, so
we use a list of mime types from the mailcap package, which is also
used by most other Linux distributions by default.
@ghost
Copy link
Author

ghost commented Aug 28, 2019

For reference, most other distributions don't ship the nginx mime.types and instead use mime.types from the mailcap package and depend on it:
https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/nginx#n114
https://src.fedoraproject.org/rpms/nginx/blob/HEAD/f/nginx.spec?h=master#_300

@peterhoeg
Copy link
Member

most other distributions don't ship the nginx mime.types

Another option would be to simply copy that file into nginx when building nginx.

@ghost
Copy link
Author

ghost commented Aug 28, 2019

most other distributions don't ship the nginx mime.types

Another option would be to simply copy that file into nginx when building nginx.

Do you see any benefit in doing so? I think other distributions don't ship the nginx mime.types, because it would create a conflict, which is a problem we don't have .

@alyssais alyssais merged commit ff0148d into NixOS:master Oct 9, 2019
@ghost ghost deleted the feature/nginx-mailcap branch October 9, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nginx mime types
3 participants
@peterhoeg @c0bw3b @alyssais