theme-obsidian2: 2.8 -> 2.9 #67501
Merged
theme-obsidian2: 2.8 -> 2.9 #67501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhoeg
requested changes
Aug 26, 2019
| @@ -2,21 +2,17 @@ | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| name = "theme-obsidian2-${version}"; | |||
There was a problem hiding this comment.
Please change this to pname and drop the -${version} part.
| postPatch = '' | ||
| sed -i -e 's|Obsidian-2-Local|Obsidian-2|' Obsidian-2/index.theme | ||
| ''; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
Please add runHook preInstall (and runHook postInstall at the end) when overriding the whole phase.
| @@ -17108,6 +17108,8 @@ in | |||
| gtk = res.gtk2; | |||
| }; | |||
|
|
|||
| theme-obsidian2 = callPackage ../data/themes/obsidian2 { }; | |||
There was a problem hiding this comment.
Yes. There is an understanding that themes are best in the data category than in the misc one. New themes have been added there, and old themes are being moved when they are updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to version 2.9
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)