Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamspeak_client: 3.3.0 -> 3.3.2 #67478

Merged
merged 1 commit into from Sep 28, 2019
Merged

teamspeak_client: 3.3.0 -> 3.3.2 #67478

merged 1 commit into from Sep 28, 2019

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Aug 26, 2019 •
edited

Motivation for this change

https://forum.teamspeak.com/threads/141134-Release-TeamSpeak-Client-3-3-2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/ph2q6mckx9fgq27j56j6gsbcm7v0v1q6-teamspeak-client-3.3.0	  941335752
/nix/store/50ykk7kzhsvr57dbhlm8v046l5bmpiz9-teamspeak-client-3.3.2	  941341200
Notify maintainers

cc @

@jojosch jojosch force-pushed the teamspeak3_client-update-3.3.2 branch from cfac728 to dbc479a Compare September 26, 2019 11:09
@nathanielbaxter
Copy link
Contributor

Looks good to me

@Lassulus
Copy link
Member

tested with nix-review, connected to a server

@Lassulus Lassulus merged commit 9ac6fc4 into NixOS:master Sep 28, 2019
@jojosch jojosch deleted the teamspeak3_client-update-3.3.2 branch September 29, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielbaxter nathanielbaxter Awaiting requested review from nathanielbaxter

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jojosch @nathanielbaxter @Lassulus