Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bfac4a6a3d2f
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8219a113d4dd
Choose a head ref
  • 6 commits
  • 4 files changed
  • 2 contributors

Commits on Aug 27, 2019

  1. forgot to save the solution

    eggrobin committed Aug 27, 2019
    Copy the full SHA
    b264756 View commit details
  2. Copy the full SHA
    484d46e View commit details
  3. Copy the full SHA
    6814e11 View commit details
  4. Copy the full SHA
    52822f0 View commit details
  5. Copy the full SHA
    c410630 View commit details
  6. Merge pull request #2311 from eggrobin/fix-the-diurnal-build

    Fix the diurnal build
    pleroy authored Aug 27, 2019
    Copy the full SHA
    8219a11 View commit details
Showing with 16 additions and 16 deletions.
  1. +1 −1 Principia.sln
  2. +12 −12 astronomy/lunar_eclipse_test.cpp
  3. +2 −2 journal/player_test.cpp
  4. +1 −1 ksp_plugin_test/interface_test.cpp
2 changes: 1 addition & 1 deletion Principia.sln
Original file line number Diff line number Diff line change
@@ -82,14 +82,14 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "base", "base\base.vcxproj",
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Scripts", "Scripts", "{B0F47E49-0EDF-4D58-AB27-F99CCCE4253A}"
ProjectSection(SolutionItems) = preProject
build_for_benchmarking.ps1 = build_for_benchmarking.ps1
debug_and_release_in_parallel.xml = debug_and_release_in_parallel.xml
find_msbuild.ps1 = find_msbuild.ps1
generate_version_translation_unit.ps1 = generate_version_translation_unit.ps1
install_deps.sh = install_deps.sh
make_principia_release.ps1 = make_principia_release.ps1
rebuild_all_solutions.ps1 = rebuild_all_solutions.ps1
rebuild_debug_and_release_in_parallel.ps1 = rebuild_debug_and_release_in_parallel.ps1
rebuild_release.ps1 = rebuild_release.ps1
EndProjectSection
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "coverage_analyser", "coverage_analyser\coverage_analyser.csproj", "{06E78A3D-AAA0-4CD9-8F23-B5BBBBE6F14F}"
24 changes: 12 additions & 12 deletions astronomy/lunar_eclipse_test.cpp
Original file line number Diff line number Diff line change
@@ -317,12 +317,12 @@ TEST_F(LunarEclipseTest, DISABLED_Year2000) {
constexpr auto U4 = "2000-01-21T06:25:09"_UT1;
constexpr auto P4 = "2000-01-21T07:22:38"_UT1;

CheckLunarPenumbralEclipse(P1, U14, 8.0e-5_⑴ * Radian, -167_⑴ * Second);
CheckLunarUmbralEclipse(U1, U14, 1.1e-4_⑴ * Radian, -164_⑴ * Second);
CheckLunarUmbralEclipse(U2, U23, 2.0e-4_⑴ * Radian, -167_⑴ * Second);
CheckLunarUmbralEclipse(U3, U23, 2.0e-4_⑴ * Radian, -160_⑴ * Second);
CheckLunarUmbralEclipse(U4, U14, 1.1e-4_⑴ * Radian, -161_⑴ * Second);
CheckLunarPenumbralEclipse(P4, U14, 7.7e-5_⑴ * Radian, -160_⑴ * Second);
CheckLunarPenumbralEclipse(P1, U14, 7.8e-5_⑴ * Radian, -162_⑴ * Second);
CheckLunarUmbralEclipse(U1, U14, 1.1e-4_⑴ * Radian, -161_⑴ * Second);
CheckLunarUmbralEclipse(U2, U23, 2.0e-4_⑴ * Radian, -163_⑴ * Second);
CheckLunarUmbralEclipse(U3, U23, 2.0e-4_⑴ * Radian, -157_⑴ * Second);
CheckLunarUmbralEclipse(U4, U14, 1.1e-4_⑴ * Radian, -157_⑴ * Second);
CheckLunarPenumbralEclipse(P4, U14, 7.5e-5_⑴ * Radian, -156_⑴ * Second);
}

TEST_F(LunarEclipseTest, DISABLED_Year2048) {
@@ -336,12 +336,12 @@ TEST_F(LunarEclipseTest, DISABLED_Year2048) {
constexpr auto U4 = "2048-01-01T08:39:33"_TT + ΔT;
constexpr auto P4 = "2048-01-01T09:52:05"_TT + ΔT;

CheckLunarPenumbralEclipse(P1, U14, 1.5e-4_⑴ * Radian, -361_⑴ * Second);
CheckLunarUmbralEclipse(U1, U14, 2.2e-4_⑴ * Radian, -359_⑴ * Second);
CheckLunarUmbralEclipse(U2, U23, 2.7e-4_⑴ * Radian, -358_⑴ * Second);
CheckLunarUmbralEclipse(U3, U23, 3.1e-4_⑴ * Radian, -360_⑴ * Second);
CheckLunarUmbralEclipse(U4, U14, 2.2e-4_⑴ * Radian, -359_⑴ * Second);
CheckLunarPenumbralEclipse(P4, U14, 1.5e-4_⑴ * Radian, -358_⑴ * Second);
CheckLunarPenumbralEclipse(P1, U14, 1.5e-4_⑴ * Radian, -358_⑴ * Second);
CheckLunarUmbralEclipse(U1, U14, 2.2e-4_⑴ * Radian, -356_⑴ * Second);
CheckLunarUmbralEclipse(U2, U23, 2.7e-4_⑴ * Radian, -356_⑴ * Second);
CheckLunarUmbralEclipse(U3, U23, 3.1e-4_⑴ * Radian, -355_⑴ * Second);
CheckLunarUmbralEclipse(U4, U14, 2.2e-4_⑴ * Radian, -355_⑴ * Second);
CheckLunarPenumbralEclipse(P4, U14, 1.5e-4_⑴ * Radian, -353_⑴ * Second);
}

#endif
4 changes: 2 additions & 2 deletions journal/player_test.cpp
Original file line number Diff line number Diff line change
@@ -80,11 +80,11 @@ TEST_F(PlayerTest, PlayTiny) {
EXPECT_EQ(2, count);
}

TEST_F(PlayerTest, DISABLED_Benchmarks) {
TEST_F(PlayerTest, DISABLED_SECULAR_Benchmarks) {
benchmark::RunSpecifiedBenchmarks();
}

TEST_F(PlayerTest, DISABLED_Debug) {
TEST_F(PlayerTest, DISABLED_SECULAR_Debug) {
// An example of how journaling may be used for debugging. You must set
// |path| and fill the |method_in| and |method_out_return| protocol buffers.
std::string path =
2 changes: 1 addition & 1 deletion ksp_plugin_test/interface_test.cpp
Original file line number Diff line number Diff line change
@@ -668,7 +668,7 @@ TEST_F(InterfaceTest, DeserializePlugin) {
}

// Use for debugging saves given by users.
TEST_F(InterfaceTest, DISABLED_DeserializePluginDebug) {
TEST_F(InterfaceTest, DISABLED_SECULAR_DeserializePluginDebug) {
Plugin const* plugin = nullptr;

// Read a plugin from a file containing only the "serialized_plugin = " lines.