qt5ct: fix missing app icon and name when running under Wayland #67559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream patch: https://sourceforge.net/p/qt5ct/tickets/69/ |
|
Would be nice to put the URL of the submitted patch in the comment, so someone coming along a year from now can easily determine whether it's out of date or not. |
Patch has been upstreamed (https://sourceforge.net/p/qt5ct/code/549/) and will be removed in the future.
lightbulbjim
force-pushed
the
qt5ct-wayland
branch
from
e0aefe7
to
42880ab
Compare
|
Fair enough, updated. Since I opened the PR the upstream dev has committed the change (https://sourceforge.net/p/qt5ct/code/549/) so I've updated the included patch to match it more closely. It doesn't look like Sourceforge has a raw diff view that we can slurp unfortunately. |
|
I don't use wayland but looks ok. |
|
@GrahamcOfBorg build qt5ct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The app icon and name were missing when running under Wayland (
QT_QPA_PLATFORM=wayland). Xorg/XWayland (QT_QPA_PLATFORM=xcb) were unaffected.The patch has been upstreamed and can be removed once a new release is available.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @Ralith