Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: add getSchemaPath, makeSchemaPath #67488

Merged
merged 4 commits into from Aug 27, 2019
Merged

glib: add getSchemaPath, makeSchemaPath #67488

merged 4 commits into from Aug 27, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Inspiration #67466 (comment)

Will update GNOME module to use this, but we should probably merge master into staging first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: pantheon The Pantheon desktop environment labels Aug 26, 2019
@ofborg ofborg bot requested review from hedning and etu August 26, 2019 10:10
@ofborg ofborg bot requested a review from jtojnar August 26, 2019 11:24
@ofborg ofborg bot requested a review from jtojnar August 27, 2019 01:43
@ofborg ofborg bot requested a review from jtojnar August 27, 2019 18:37
@worldofpeace
Copy link
Contributor Author

Does this need to go to staging?

@jtojnar
Copy link
Contributor

jtojnar commented Aug 27, 2019

I would say it does not but there is a merge conflict.

@worldofpeace
Copy link
Contributor Author

I would say it does not but there is a merge conflict.

Yeah, I'm probably too lazy for that. So off it goes 😊️

@worldofpeace worldofpeace merged commit 6402a04 into NixOS:staging Aug 27, 2019
@worldofpeace worldofpeace deleted the glib/get-schema-path branch August 27, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@hedning hedning Awaiting requested review from hedning

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar