classicube: init at 1.0.7 #67569
classicube: init at 1.0.7 #67569
Conversation
marius851000
force-pushed
the
classicube
branch
from
79b5913
to
9dddcb3
Compare
|
@mmahut I've corrected what you said (The patch is from me) |
| rm -f ~/.ClassiCube/ClassiCubeBin | ||
| cp $out/bin/.ClassiCube ~/.ClassiCube/ClassiCubeBin | ||
| ~/.ClassiCube/ClassiCubeBin | ||
| rm -f ~/.ClassiCube/ClassiCubeBin" > $out/bin/ClassiCube |
There was a problem hiding this comment.
I ran into the same situation when packaging clonehero: https://github.com/MetaDark/nixpkgs/blob/589715d52395ebb2c2c7813733649bb37b593f14/pkgs/games/clonehero/default.nix#L92-L93.
I discovered that you can fake argv[0] so that the binary thinks it was launched from another location. That way you don't need to copy the binary.
I would also recommend following the XDG Base Directory Specification rather storing files directly in the user's home directory: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html.
There was a problem hiding this comment.
Hmm, actually looking into the source code it looks like it reads the path from /proc/self/exe rather than argv[0]. I tested it with a sample script and the exec -a workaround doesn't seem to work.
There was a problem hiding this comment.
Now I found the function that indicate the function that find the binary name, I can just patch it (I suppose)
There was a problem hiding this comment.
Can you please patch it? This is a not very great workaround.
marius851000
force-pushed
the
classicube
branch
from
9dddcb3
to
6530842
Compare
|
I don't know how to change the function that return the binary path, but I've updated to the 1.0.7 version. |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
| postUnpack = '' | ||
| sourceRoot=$sourceRoot/src | ||
| ''; |
There was a problem hiding this comment.
| postUnpack = '' | |
| sourceRoot=$sourceRoot/src | |
| ''; | |
| sourceRoot="$sourceRoot/src"; |
stale
bot
removed
the
2.status: stale
| font = "${liberation-sans-narrow}/share/fonts/truetype/LiberationSansNarrow-Regular.ttf"; | ||
|
|
||
| postPatch = '' | ||
| substituteInPlace Platform.c --replace %fontdir% ${font} |
There was a problem hiding this comment.
| font = "${liberation-sans-narrow}/share/fonts/truetype/LiberationSansNarrow-Regular.ttf"; | |
| postPatch = '' | |
| substituteInPlace Platform.c --replace %fontdir% ${font} | |
| postPatch = '' | |
| substituteInPlace Platform.c --replace %fontdir% ${liberation-sans-narrow}/share/fonts/truetype/LiberationSansNarrow-Regular.ttf |
| substituteInPlace Makefile --replace JOBS=1 JOBS=${ if enableParallelBuilding then "$NIX_BUILD_CORES" else "1"} | ||
| ''; |
There was a problem hiding this comment.
Can you make this conditional on enableParallelBuilding and replace JOBS with NIX_BUILD_CORES? Also NIX_BUILD_CORES should always be 1 or more I think.
There was a problem hiding this comment.
No really sure about what you mean. Do you mean using --replace JOBS "" --replace JOBS NIX_BUILD_CORES ?
| rm -f ~/.ClassiCube/ClassiCubeBin | ||
| cp $out/bin/.ClassiCube ~/.ClassiCube/ClassiCubeBin | ||
| ~/.ClassiCube/ClassiCubeBin | ||
| rm -f ~/.ClassiCube/ClassiCubeBin" > $out/bin/ClassiCube |
There was a problem hiding this comment.
Can you please patch it? This is a not very great workaround.
|
This took me far too much time compared to what I play of it. I'll close this PR. Anyone is free to continue this if they want (the main problem is patching the save directory). The code that seem to be used to save stuff are in the Platform.c file. They seem to use standard glibc function. |
Motivation for this change
Someone requested classicube, as I had free time, I've done this.
Things done
Tested singleplayer and work well.
Multiplayer untested.
The game write file relative to it's binary, so I move it in ~/.ClassiCube before running it.
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)