Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains: 2019.2.* #67539

Merged
merged 10 commits into from Aug 27, 2019
Merged

jetbrains: 2019.2.* #67539

merged 10 commits into from Aug 27, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 27, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@eadwu eadwu requested a review from edwtjo as a code owner August 27, 2019 01:04
@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

1 package failed to build:
jetbrains.webstorm

builder for '/nix/store/n332j1m0m89mmwrw88n1317wpxamhi3i-webstorm-2019.2.1.drv' failed with exit code 1; last 6 log lines:
  unpacking sources
  unpacking source archive /nix/store/fx6wrmms8aalapfxxwjybk889nfr9azj-WebStorm-2019.2.1.tar.gz
  source root is WebStorm-192.6262.59
  setting SOURCE_DATE_EPOCH to timestamp 1566316279 of file WebStorm-192.6262.59/product-info.json
  patching sources
  rm: cannot remove 'jre64': No such file or directory
cannot build derivation '/nix/store/h3869vark9813cff1s0qwa7n1sigywkj-env.drv': 1 dependencies couldn't be built

@eadwu
Copy link
Member Author

eadwu commented Aug 27, 2019

Dropped webstorm bump.

@mmahut
Copy link
Member

mmahut commented Aug 27, 2019

Thank you, all of the above builds fine.

@mmahut mmahut merged commit 4018166 into NixOS:master Aug 27, 2019
@DavidDudson
Copy link

@eadwu @mmahut See #65383 For how webstorm can be resolved

@eadwu eadwu mentioned this pull request Aug 29, 2019
Merged
10 tasks
@eadwu eadwu deleted the jetbrains/update-1 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @mmahut @DavidDudson