pythonPackages.fire: 0.1.3 -> 0.2.1 #67571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Apparently, the python2 version requires ➜ ~ NIX_PATH=nixpkgs=${HOME}/.cache/nix-review/pr-67571-2/nixpkgs nix-shell -p 'python.withPackages (ps: [ ps.fire ])' --command "python -c 'import fire'"
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/nix/store/f04jmfb4cl7qmaqps27phbi98siy6539-python-2.7.16-env/lib/python2.7/site-packages/fire/__init__.py", line 21, in <module>
from fire.core import Fire
File "/nix/store/f04jmfb4cl7qmaqps27phbi98siy6539-python-2.7.16-env/lib/python2.7/site-packages/fire/core.py", line 65, in <module>
from fire import completion
File "/nix/store/f04jmfb4cl7qmaqps27phbi98siy6539-python-2.7.16-env/lib/python2.7/site-packages/fire/completion.py", line 25, in <module>
from fire import inspectutils
File "/nix/store/f04jmfb4cl7qmaqps27phbi98siy6539-python-2.7.16-env/lib/python2.7/site-packages/fire/inspectutils.py", line 22, in <module>
from fire import docstrings
File "/nix/store/f04jmfb4cl7qmaqps27phbi98siy6539-python-2.7.16-env/lib/python2.7/site-packages/fire/docstrings.py", line 61, in <module>
import enum
ImportError: No module named enumCould you add it as an optional dependency for the python2 version? |
|
Reported upstream in google/python-fire#191 |
jonringer
approved these changes
Aug 28, 2019
There was a problem hiding this comment.
Odd, I was able to run the tests without needing the enum module
nix-review passes on NixOS
diff LGTM (Although, it should apply Isix's fixes)
leaf package
[4 built, 15 copied (10.3 MiB), 1.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67571
2 package were build:
python27Packages.fire python37Packages.fire
Added. Thanks for reporting upstream, @lsix |
|
👍 Just tested the result, all good for me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Version bump.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @