Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exiv2: enabling tests for real #67489

Merged
merged 2 commits into from Aug 26, 2019
Merged

exiv2: enabling tests for real #67489

merged 2 commits into from Aug 26, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 26, 2019 •
edited

Motivation for this change

Fixes #67453, which disabled all tests by mistake, given I have assumed doCheck defaults to true if tests are found.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as soon as the darwin check passes.

@mmahut
Copy link
Member Author

mmahut commented Aug 26, 2019

Looks like darwin is stuck.

@GrahamcOfBorg build exiv2

@mmahut
Copy link
Member Author

mmahut commented Aug 26, 2019 •
edited

@worldofpeace now, the tests are failing on darwin instead of aarch64.

dyld: Library not loaded: Reason: image not found

@mmahut mmahut force-pushed the exiv2 branch 2 times, most recently from 6a3e2cf to a63d342 Compare August 26, 2019 14:00
@mmahut
Copy link
Member Author

mmahut commented Aug 26, 2019

@GrahamcOfBorg build exiv2

@mmahut
Copy link
Member Author

mmahut commented Aug 26, 2019

@GrahamcOfBorg build exiv2

@mmahut
Copy link
Member Author

mmahut commented Aug 26, 2019

@GrahamcOfBorg build exiv2

Ok, last try and I disable the tests of darwin :)

@mmahut
Copy link
Member Author

mmahut commented Aug 26, 2019

@GrahamcOfBorg build exiv2

@mmahut mmahut merged commit bfcab98 into NixOS:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @worldofpeace