Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: update mailman to version 3.2.2 #67461

Closed
wants to merge 11 commits into from

Conversation

peti
Copy link
Member

@peti peti commented Aug 25, 2019

I would normally not merge a major version bump from Mailman 2.x to 3.x to a stable release branch, but I am pretty sure that nobody has been using this package. It was never in a usable shape without major glue code and/or a NixOS module. I'd like to remedy those issue now and I'd rather start that effort based on a current version of Mailman.

@globin
Copy link
Member

globin commented Aug 26, 2019

You might want to have a look at a very hacky version of a mailman 3 module:
https://github.com/mayflower/nixexprs/blob/master/modules/mailman3.nix

@peti
Copy link
Member Author

peti commented Aug 26, 2019

You might want to have a look at a very hacky version of a mailman 3 module:
https://github.com/mayflower/nixexprs/blob/master/modules/mailman3.nix

Very cool, thank you for the pointer!

@lheckemann
Copy link
Member

I'm not sure I really understand why for release-19.03, especially when 19.09 isn't that far off (branch-off in 11 days).

@peti peti changed the title update mailman to version 3.2.2 WIP: update mailman to version 3.2.2 Aug 27, 2019
@peti peti added this to the 19.09 milestone Aug 27, 2019
@peti
Copy link
Member Author

peti commented Aug 27, 2019

I'm not sure I really understand why for release-19.03, especially when 19.09 isn't that far off (branch-off in 11 days).

Yeah, that is a good point. I had not considered that 19.09 is not that far away, really. I guess I can simply develop that code on master now and run my mail server on the 19.09 test branch once it's created.

nixos/modules/misc/ids.nix Show resolved Hide resolved
nixos/modules/services/mail/mailman.nix Show resolved Hide resolved
nixos/modules/services/mail/mailman.nix Show resolved Hide resolved

systemd.services.mailman = {
description = "GNU Mailman Master Process";
after = [ "network.target" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be network-online.target instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@globin Why do you disagree?

nixos/modules/services/mail/mailman.nix Show resolved Hide resolved
@peti
Copy link
Member Author

peti commented Aug 29, 2019

Superseded by #67708.

@peti peti closed this Aug 29, 2019
@peti peti deleted the t/mailman-v3-for-19.03 branch August 29, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants